{"html_url": "https://github.com/simonw/datasette/issues/14#issuecomment-345893877", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/14", "id": 345893877, "node_id": "MDEyOklzc3VlQ29tbWVudDM0NTg5Mzg3Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-11-21T02:11:27Z", "updated_at": "2017-11-21T02:11:27Z", "author_association": "OWNER", "body": "http://setuptools.readthedocs.io/en/latest/setuptools.html#dynamic-discovery-of-services-and-plugins Is pretty good ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 267707940, "label": "Datasette Plugins"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/104#issuecomment-346116745", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/104", "id": 346116745, "node_id": "MDEyOklzc3VlQ29tbWVudDM0NjExNjc0NQ==", "user": {"value": 21148, "label": "jacobian"}, "created_at": "2017-11-21T18:23:25Z", "updated_at": "2017-11-21T18:23:25Z", "author_association": "CONTRIBUTOR", "body": "@simonw ready for a review and merge if you want.\r\n\r\nThere's still some nasty duplicated code in cli.py and utils.py, which is just going to get worse if/when we start adding any other deploy targets (and I want to do one for cloud.gov, at least). I think there's an opportunity for some refactoring here. I'm happy to do that now as part of this PR, or if you merge this first I'll do it in a different one.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 274284246, "label": "[WIP] Add publish to heroku support"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/104#issuecomment-346124073", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/104", "id": 346124073, "node_id": "MDEyOklzc3VlQ29tbWVudDM0NjEyNDA3Mw==", "user": {"value": 21148, "label": "jacobian"}, "created_at": "2017-11-21T18:49:55Z", "updated_at": "2017-11-21T18:49:55Z", "author_association": "CONTRIBUTOR", "body": "Actually hang on, don't merge - there are some bugs that #141 masked when I tested this out elsewhere.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 274284246, "label": "[WIP] Add publish to heroku support"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/104#issuecomment-346124764", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/104", "id": 346124764, "node_id": "MDEyOklzc3VlQ29tbWVudDM0NjEyNDc2NA==", "user": {"value": 21148, "label": "jacobian"}, "created_at": "2017-11-21T18:52:14Z", "updated_at": "2017-11-21T18:52:14Z", "author_association": "CONTRIBUTOR", "body": "OK, now this should work.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 274284246, "label": "[WIP] Add publish to heroku support"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/141#issuecomment-346157542", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/141", "id": 346157542, "node_id": "MDEyOklzc3VlQ29tbWVudDM0NjE1NzU0Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-11-21T20:53:47Z", "updated_at": "2017-11-21T20:53:47Z", "author_association": "OWNER", "body": "I think a copy is the right thing to do here - it will be cleaned up when the temp directory is removed. The hard link thing was always intended to save space, but if we can't do a hard link I don't see any harm in a temporary file copy.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 275814941, "label": "datasette publish can fail if /tmp is on a different device"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/90#issuecomment-346161985", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/90", "id": 346161985, "node_id": "MDEyOklzc3VlQ29tbWVudDM0NjE2MTk4NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-11-21T21:10:22Z", "updated_at": "2017-11-21T21:10:22Z", "author_association": "OWNER", "body": "Woohoo!\r\n\r\nI've found one tiny issue: right now, the following doesn't work:\r\n\r\n    datasette publish heroku ../demo-databses/google-trends.db\r\n\r\nIt results in this error in the Heroku logs:\r\n\r\n    2017-11-21T21:03:29.210511+00:00 app[web.1]: Usage: datasette serve [OPTIONS] [FILES]...\r\n    2017-11-21T21:03:29.210524+00:00 app[web.1]: \r\n    2017-11-21T21:03:29.210555+00:00 app[web.1]: Error: Invalid value for \"files\": Path \"../demo-databses/google-trends.db\" does not exist.\r\n\r\nThe command works fine if you run it in the same directory as the database file you are publishing.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 273846123, "label": "datasette publish heroku"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/90#issuecomment-346163513", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/90", "id": 346163513, "node_id": "MDEyOklzc3VlQ29tbWVudDM0NjE2MzUxMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2017-11-21T21:16:16Z", "updated_at": "2017-11-21T21:16:16Z", "author_association": "OWNER", "body": "The reason relative paths work for `publish now` is that the `make_dockerfile()` function is called by passing the file names, not the full file paths:\r\n\r\nhttps://github.com/simonw/datasette/blob/e47117ce1d15f11246a3120aa49de70205713d05/datasette/utils.py#L166\r\n\r\nClearly the correct thing to do here is for us to refactor the shared code between heroku/package/now.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 273846123, "label": "datasette publish heroku"}, "performed_via_github_app": null}