{"html_url": "https://github.com/simonw/datasette/issues/393#issuecomment-450943172", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/393", "id": 450943172, "node_id": "MDEyOklzc3VlQ29tbWVudDQ1MDk0MzE3Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-01-02T18:28:43Z", "updated_at": "2019-01-02T18:28:43Z", "author_association": "OWNER", "body": "Definitely a bug, thanks.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 395236066, "label": "CSV export in \"Advanced export\" pane doesn't respect query"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/393#issuecomment-450943632", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/393", "id": 450943632, "node_id": "MDEyOklzc3VlQ29tbWVudDQ1MDk0MzYzMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-01-02T18:30:20Z", "updated_at": "2019-01-02T18:30:20Z", "author_association": "OWNER", "body": "This is the code which is meant to add those options as hidden form fields:\r\n\r\nhttps://github.com/simonw/datasette/blob/fe5b6ea95a973534fe8a44907c0ea2449aae7602/datasette/templates/table.html#L150-L155\r\n\r\nIt's clearly not working. Need to fix this and add a corresponding unit test.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 395236066, "label": "CSV export in \"Advanced export\" pane doesn't respect query"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/393#issuecomment-450944166", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/393", "id": 450944166, "node_id": "MDEyOklzc3VlQ29tbWVudDQ1MDk0NDE2Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-01-02T18:32:12Z", "updated_at": "2019-01-02T18:32:12Z", "author_association": "OWNER", "body": "Here's the test that needs updating:\r\n\r\nhttps://github.com/simonw/datasette/blob/8b8ae55e7c8b9e1dceef53f55a330b596ca44d41/tests/test_html.py#L427-L435", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 395236066, "label": "CSV export in \"Advanced export\" pane doesn't respect query"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/391#issuecomment-450964512", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/391", "id": 450964512, "node_id": "MDEyOklzc3VlQ29tbWVudDQ1MDk2NDUxMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-01-02T19:45:12Z", "updated_at": "2019-01-02T19:45:12Z", "author_association": "OWNER", "body": "Thanks, I've fixed this. I had to re-alias it against now:\r\n```\r\n~ $ now alias google-trends-pnwhfwvgqf.now.sh https://google-trends.datasettes.com/\r\n> Assigning alias google-trends.datasettes.com to deployment google-trends-pnwhfwvgqf.now.sh\r\n> Certificate for google-trends.datasettes.com (cert_uXaADIuNooHS3tZ) created [18s]\r\n> Success! google-trends.datasettes.com now points to google-trends-pnwhfwvgqf.now.sh [20s]\r\n```", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 392610803, "label": "Google Trends example doesn\u2019t work"}, "performed_via_github_app": null}