{"html_url": "https://github.com/simonw/datasette/issues/906#issuecomment-663720907", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/906", "id": 663720907, "node_id": "MDEyOklzc3VlQ29tbWVudDY2MzcyMDkwNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-24T20:29:24Z", "updated_at": "2020-07-24T20:29:24Z", "author_association": "OWNER", "body": "Here are the existing test cases:\r\nhttps://github.com/simonw/datasette/blob/2115d7e3457b48b3cf9c81551b9fed2d0e9cd111/tests/test_utils.py#L468-L505", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 665400224, "label": "\"allow\": true for anyone, \"allow\": false for nobody"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/902#issuecomment-663724425", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/902", "id": 663724425, "node_id": "MDEyOklzc3VlQ29tbWVudDY2MzcyNDQyNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-24T20:38:42Z", "updated_at": "2020-07-24T20:38:42Z", "author_association": "OWNER", "body": "Thanks for spotting this!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 662439034, "label": "Don't install tests package"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/456#issuecomment-663724675", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/456", "id": 663724675, "node_id": "MDEyOklzc3VlQ29tbWVudDY2MzcyNDY3NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-24T20:39:17Z", "updated_at": "2020-07-24T20:39:17Z", "author_association": "OWNER", "body": "Yes this is still a bug!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 442327592, "label": "Installing installs the tests package"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/907#issuecomment-663726146", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/907", "id": 663726146, "node_id": "MDEyOklzc3VlQ29tbWVudDY2MzcyNjE0Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-24T20:43:27Z", "updated_at": "2020-07-24T20:43:27Z", "author_association": "OWNER", "body": "It might be good to have a little interactive tool which helps debug these things, since there are quite a few edge-cases and the damage caused if people use them incorrectly is substantial.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 665403403, "label": "Allow documentation doesn't explain what happens with multiple allow keys"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/908#issuecomment-663726318", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/908", "id": 663726318, "node_id": "MDEyOklzc3VlQ29tbWVudDY2MzcyNjMxOA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-24T20:43:57Z", "updated_at": "2020-07-24T20:45:38Z", "author_association": "OWNER", "body": "I can implement this as a plugin. Or it could ship as part of Datasette, somewhere under the `/-/` namespace like the `PermissionsDebugView` and `MessagesDebugView` tools.\r\n\r\nI'm going to ship it in Datasette core, to further reinforce the philosophy that debugging tools are important.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 665407663, "label": "Interactive debugging tool for \"allow\" blocks"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/901#issuecomment-663727716", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/901", "id": 663727716, "node_id": "MDEyOklzc3VlQ29tbWVudDY2MzcyNzcxNg==", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2020-07-24T20:47:57Z", "updated_at": "2020-07-24T20:47:57Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/901?src=pr&el=h1) Report\n> Merging [#901](https://codecov.io/gh/simonw/datasette/pull/901?src=pr&el=desc) into [master](https://codecov.io/gh/simonw/datasette/commit/d9a5ef1c32a4390e398653ebfd570f8e1a03d93e&el=desc) will **decrease** coverage by `0.00%`.\n> The diff coverage is `83.33%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/901/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1)](https://codecov.io/gh/simonw/datasette/pull/901?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## master #901 +/- ##\n==========================================\n- Coverage 83.41% 83.41% -0.01% \n==========================================\n Files 27 27 \n Lines 3636 3642 +6 \n==========================================\n+ Hits 3033 3038 +5 \n- Misses 603 604 +1 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/901?src=pr&el=tree) | Coverage \u0394 | |\n|---|---|---|\n| [datasette/utils/\\_\\_init\\_\\_.py](https://codecov.io/gh/simonw/datasette/pull/901/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL3V0aWxzL19faW5pdF9fLnB5) | `93.76% <66.66%> (-0.18%)` | :arrow_down: |\n| [datasette/filters.py](https://codecov.io/gh/simonw/datasette/pull/901/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL2ZpbHRlcnMucHk=) | `94.35% <100.00%> (+0.09%)` | :arrow_up: |\n| [datasette/utils/asgi.py](https://codecov.io/gh/simonw/datasette/pull/901/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL3V0aWxzL2FzZ2kucHk=) | `91.47% <0.00%> (+0.07%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/901?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `\u0394 = absolute (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/901?src=pr&el=footer). Last update [d9a5ef1...1285f28](https://codecov.io/gh/simonw/datasette/pull/901?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 662322234, "label": "Use None as a default arg"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/907#issuecomment-663764203", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/907", "id": 663764203, "node_id": "MDEyOklzc3VlQ29tbWVudDY2Mzc2NDIwMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-24T22:53:07Z", "updated_at": "2020-07-24T22:53:07Z", "author_association": "OWNER", "body": "Actually that is already covered here: \r\nhttps://github.com/simonw/datasette/blob/6be5654ffab282e8cf39cc138ba2d4496ebc7407/docs/authentication.rst#L158", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 665403403, "label": "Allow documentation doesn't explain what happens with multiple allow keys"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/908#issuecomment-663765308", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/908", "id": 663765308, "node_id": "MDEyOklzc3VlQ29tbWVudDY2Mzc2NTMwOA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-24T22:57:15Z", "updated_at": "2020-07-24T22:57:15Z", "author_association": "OWNER", "body": "Tool lives at https://latest.datasette.io/-/allow-debug", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 665407663, "label": "Interactive debugging tool for \"allow\" blocks"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/906#issuecomment-663767678", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/906", "id": 663767678, "node_id": "MDEyOklzc3VlQ29tbWVudDY2Mzc2NzY3OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-24T23:07:22Z", "updated_at": "2020-07-24T23:07:22Z", "author_association": "OWNER", "body": "Illustration of current system:\r\n\r\nhttps://latest.datasette.io/-/allow-debug?actor=%7B%0D%0A++++%22id%22%3A+%22terry%22%0D%0A%7D&allow=null - `null` allows\r\n\r\nhttps://latest.datasette.io/-/allow-debug?actor=%7B%0D%0A++++%22id%22%3A+%22terry%22%0D%0A%7D&allow={} - `{}` denies", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 665400224, "label": "\"allow\": true for anyone, \"allow\": false for nobody"}, "performed_via_github_app": null}