{"html_url": "https://github.com/simonw/datasette/pull/1059#issuecomment-717938992", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1059", "id": 717938992, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNzkzODk5Mg==", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2020-10-28T13:38:46Z", "updated_at": "2020-10-28T13:38:46Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/1059?src=pr&el=h1) Report\n> Merging [#1059](https://codecov.io/gh/simonw/datasette/pull/1059?src=pr&el=desc) into [main](https://codecov.io/gh/simonw/datasette/commit/7d9fedc176717a7e3d22a96575ae0aada5a65440?el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1059/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1)](https://codecov.io/gh/simonw/datasette/pull/1059?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## main #1059 +/- ##\n=======================================\n Coverage 84.71% 84.71% \n=======================================\n Files 28 28 \n Lines 3957 3957 \n=======================================\n Hits 3352 3352 \n Misses 605 605 \n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1059?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `\u0394 = absolute (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1059?src=pr&el=footer). Last update [7d9fedc...e46327a](https://codecov.io/gh/simonw/datasette/pull/1059?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 731445447, "label": "Update aiofiles requirement from <0.6,>=0.4 to >=0.4,<0.7"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1059#issuecomment-718078447", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1059", "id": 718078447, "node_id": "MDEyOklzc3VlQ29tbWVudDcxODA3ODQ0Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-28T17:07:59Z", "updated_at": "2020-10-28T17:08:14Z", "author_association": "OWNER", "body": "> #### 0.6.0 (2020-10-27)\r\n> \r\n> - aiofiles is now tested on ppc64le.\r\n> - Added name and mode properties to async file objects. [#82](https://github.com/Tinche/aiofiles/pull/82)\r\n> - Fixed a DeprecationWarning internally. [#75](https://github.com/Tinche/aiofiles/pull/75)\r\n> - Python 3.9 support and tests.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 731445447, "label": "Update aiofiles requirement from <0.6,>=0.4 to >=0.4,<0.7"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/sqlite-utils/issues/191#issuecomment-718168730", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/191", "id": 718168730, "node_id": "MDEyOklzc3VlQ29tbWVudDcxODE2ODczMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-28T19:47:20Z", "updated_at": "2020-10-28T19:47:20Z", "author_association": "OWNER", "body": "https://stackoverflow.com/a/3931903 looks useful:\r\n```python\r\ndef trace(*args):\r\n def _trace(func):\r\n def wrapper(*args, **kwargs):\r\n print enter_string\r\n func(*args, **kwargs)\r\n print exit_string\r\n return wrapper\r\n if len(args) == 1 and callable(args[0]):\r\n # No arguments, this is the decorator\r\n # Set default values for the arguments\r\n enter_string = 'entering'\r\n exit_string = 'exiting'\r\n return _trace(args[0])\r\n else:\r\n # This is just returning the decorator\r\n enter_string, exit_string = args\r\n return _trace\r\n```\r\nCan improve that code with `functools.wraps`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 731740458, "label": "Idea: @db.register_function(deterministic=True)"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/sqlite-utils/issues/191#issuecomment-718170295", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/191", "id": 718170295, "node_id": "MDEyOklzc3VlQ29tbWVudDcxODE3MDI5NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-28T19:50:16Z", "updated_at": "2020-10-28T19:50:16Z", "author_association": "OWNER", "body": "I think I made a mistake when I designed the initial decorator. I should have had it work like this:\r\n\r\n```python\r\n@db.register_function()\r\ndef reverse_string(s):\r\n return \"\".join(reversed(list(s)))\r\n```\r\nAs this leaves open the option to add new parameters in the future.\r\n\r\nTo avoid breaking backwards compatibility I'll use the hack that detects the argument this time, but in the future I'll try to remember to always design decorators to be called like `@decorator()`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 731740458, "label": "Idea: @db.register_function(deterministic=True)"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1060#issuecomment-718243062", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1060", "id": 718243062, "node_id": "MDEyOklzc3VlQ29tbWVudDcxODI0MzA2Mg==", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2020-10-28T22:23:33Z", "updated_at": "2020-10-28T22:23:33Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/1060?src=pr&el=h1) Report\n> Merging [#1060](https://codecov.io/gh/simonw/datasette/pull/1060?src=pr&el=desc) into [main](https://codecov.io/gh/simonw/datasette/commit/abcf0222496d8148b2e585ffa0ff192270a04b06?el=desc) will **increase** coverage by `6.42%`.\n> The diff coverage is `100.00%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1060/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1)](https://codecov.io/gh/simonw/datasette/pull/1060?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## main #1060 +/- ##\n==========================================\n+ Coverage 84.71% 91.13% +6.42% \n==========================================\n Files 28 27 -1 \n Lines 3957 3677 -280 \n==========================================\n- Hits 3352 3351 -1 \n+ Misses 605 326 -279 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1060?src=pr&el=tree) | Coverage \u0394 | |\n|---|---|---|\n| [datasette/cli.py](https://codecov.io/gh/simonw/datasette/pull/1060/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL2NsaS5weQ==) | `73.63% <100.00%> (+0.13%)` | :arrow_up: |\n| [datasette/version.py](https://codecov.io/gh/simonw/datasette/pull/1060/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL3ZlcnNpb24ucHk=) | `100.00% <100.00%> (\u00f8)` | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1060?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `\u0394 = absolute (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1060?src=pr&el=footer). Last update [abcf022...4725d46](https://codecov.io/gh/simonw/datasette/pull/1060?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 731827081, "label": "New explicit versioning mechanism"}, "performed_via_github_app": null}