{"html_url": "https://github.com/simonw/datasette/issues/1603#issuecomment-1016579661", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1603", "id": 1016579661, "node_id": "IC_kwDOBm6k_c48l8ZN", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-19T15:27:05Z", "updated_at": "2022-01-19T15:27:05Z", "author_association": "OWNER", "body": "I'd like this to be customizable. I'm going to load it from the template loading system such that a custom favicon for a specific instance can be dropped in using a file in `templates/`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1108235694, "label": "A proper favicon"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1603#issuecomment-1016588326", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1603", "id": 1016588326, "node_id": "IC_kwDOBm6k_c48l-gm", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-19T15:35:33Z", "updated_at": "2022-01-19T15:35:33Z", "author_association": "OWNER", "body": "I don't think abusing the template loader mechanism for this will work: Jinja provides an API for loading text templates, but I don't think it can be sensibly abused to open binary image files instead. Loaded code is here: https://github.com/pallets/jinja/blob/main/src/jinja2/loaders.py", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1108235694, "label": "A proper favicon"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1603#issuecomment-1016589140", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1603", "id": 1016589140, "node_id": "IC_kwDOBm6k_c48l-tU", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-19T15:36:16Z", "updated_at": "2022-01-19T15:36:16Z", "author_association": "OWNER", "body": "For the moment then I will hard-code a new favicon and leave it to ASGI plugins if people want to define their own.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1108235694, "label": "A proper favicon"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1603#issuecomment-1016589519", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1603", "id": 1016589519, "node_id": "IC_kwDOBm6k_c48l-zP", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-19T15:36:38Z", "updated_at": "2022-01-19T15:36:38Z", "author_association": "OWNER", "body": "Also people can use a custom base template and link to a custom favicon if they want to.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1108235694, "label": "A proper favicon"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1604#issuecomment-1016636561", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1604", "id": 1016636561, "node_id": "IC_kwDOBm6k_c48mKSR", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-19T16:23:54Z", "updated_at": "2022-01-19T16:23:54Z", "author_association": "OWNER", "body": "Potential design:\r\n\r\n    datasette publish cloudrun data.db \\\r\n      --service my-service \\\r\n      --domain demo.datasette.io\r\n\r\nI think I'm OK with calling this `--domain` even when it is being used with a subdomain.\r\n\r\nThis will require `datasette.io` to already have been verified with Google.\r\n\r\nNot sure how best to handle the DNS part - maybe print out instructions for the necessary CNAME?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1108300685, "label": "Option to assign a domain/subdomain using `datasette publish cloudrun`"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1601#issuecomment-1016637722", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1601", "id": 1016637722, "node_id": "IC_kwDOBm6k_c48mKka", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-19T16:25:07Z", "updated_at": "2022-01-19T16:25:07Z", "author_association": "OWNER", "body": "Good idea - though I'm nervous about accidentally hiding a `data_licenses` table outside of the SpatiaLite case. I'll only hide that one if SpatiaLite is loaded.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1105916061, "label": "Add KNN and data_licenses to hidden tables list"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1601#issuecomment-1016651485", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1601", "id": 1016651485, "node_id": "IC_kwDOBm6k_c48mN7d", "user": {"value": 25778, "label": "eyeseast"}, "created_at": "2022-01-19T16:39:03Z", "updated_at": "2022-01-19T16:39:03Z", "author_association": "CONTRIBUTOR", "body": "I think both of these are Spatialite specific. They get generated when you first initialize the extension. KNN is actually deprecated in favor of [KNN2](https://www.gaia-gis.it/fossil/libspatialite/wiki?name=KNN2), as I understand it.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1105916061, "label": "Add KNN and data_licenses to hidden tables list"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1605#issuecomment-1016977725", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1605", "id": 1016977725, "node_id": "IC_kwDOBm6k_c48ndk9", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-19T23:55:08Z", "updated_at": "2022-01-19T23:55:08Z", "author_association": "OWNER", "body": "Oh that's interesting. I was thinking about this from a slightly different angle recently - pondering what a static site generator built on top of Datasette might look like.\r\n\r\nJust a sketch at the moment, but I was imagining a YAML configuration file with a SQL query that returns a list of paths - then a tool that runs that query and uses the equivalent of `datasette --get` to create a static copy of each of those paths.\r\n\r\nI think these two ideas can probably be merged. I'd love to know more about how you are solving this right now!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1108671952, "label": "Scripted exports"}, "performed_via_github_app": null}