{"html_url": "https://github.com/simonw/datasette/issues/1670#issuecomment-1076638278", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1670", "id": 1076638278, "node_id": "IC_kwDOBm6k_c5ALDJG", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-23T17:50:55Z", "updated_at": "2022-03-23T17:50:55Z", "author_association": "OWNER", "body": "Release notes are mostly written for the alpha, just need to clean them up a bit https://github.com/simonw/datasette/blob/c4c9dbd0386e46d2bf199f0ed34e4895c98cb78c/docs/changelog.rst#061a0-2022-03-19", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1174423568, "label": "Ship Datasette 0.61"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1665#issuecomment-1076644362", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1665", "id": 1076644362, "node_id": "IC_kwDOBm6k_c5ALEoK", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-23T17:55:39Z", "updated_at": "2022-03-23T17:55:39Z", "author_association": "OWNER", "body": "Thanks for the PR - I spotted an error about this and went through and fixed this in all of my repos the other day: https://github.com/search?o=desc&q=user%3Asimonw+google-github-actions%2Fsetup-gcloud%40v0&s=committer-date&type=Commits", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1173828092, "label": "Pin setup-gcloud to v0 instead of master"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1574#issuecomment-1076645636", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1574", "id": 1076645636, "node_id": "IC_kwDOBm6k_c5ALE8E", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-23T17:56:35Z", "updated_at": "2022-03-23T17:56:35Z", "author_association": "OWNER", "body": "I'd actually like to switch to slim as the default - I think Datasette should ship the smallest possible container that can still support extra packages being installed using `apt-get install`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1084193403, "label": "introduce new option for datasette package to use a slim base image"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1670#issuecomment-1076647495", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1670", "id": 1076647495, "node_id": "IC_kwDOBm6k_c5ALFZH", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-23T17:58:16Z", "updated_at": "2022-03-23T17:58:16Z", "author_association": "OWNER", "body": "I think the release notes are fine, but they need an opening paragraph highlighting the changes that are most likely to break backwards compatibility.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1174423568, "label": "Ship Datasette 0.61"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1670#issuecomment-1076652046", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1670", "id": 1076652046, "node_id": "IC_kwDOBm6k_c5ALGgO", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-23T18:02:30Z", "updated_at": "2022-03-23T18:02:30Z", "author_association": "OWNER", "body": "Two new things to add to the release notes from https://github.com/simonw/datasette/compare/0.61a0...main\r\n- https://github.com/simonw/datasette/issues/1678\r\n- https://github.com/simonw/datasette/issues/1675 (now also a documented API)", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1174423568, "label": "Ship Datasette 0.61"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/sqlite-utils/pull/419#issuecomment-1076662556", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/419", "id": 1076662556, "node_id": "IC_kwDOCGYnMM5ALJEc", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2022-03-23T18:12:47Z", "updated_at": "2022-03-23T18:12:47Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/sqlite-utils/pull/419?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\n> Merging [#419](https://codecov.io/gh/simonw/sqlite-utils/pull/419?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (228f736) into [main](https://codecov.io/gh/simonw/sqlite-utils/commit/93fa79d30b1531bea281d0eb6b925c4e61bc1aa6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (93fa79d) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n```diff\n@@ Coverage Diff @@\n## main #419 +/- ##\n=======================================\n Coverage 96.55% 96.55% \n=======================================\n Files 6 6 \n Lines 2498 2498 \n=======================================\n Hits 2412 2412 \n Misses 86 86 \n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/sqlite-utils/pull/419?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n> `\u0394 = absolute (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/sqlite-utils/pull/419?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Last update [93fa79d...228f736](https://codecov.io/gh/simonw/sqlite-utils/pull/419?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1178484369, "label": "Ignore common generated files"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1670#issuecomment-1076665837", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1670", "id": 1076665837, "node_id": "IC_kwDOBm6k_c5ALJ3t", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-23T18:16:01Z", "updated_at": "2022-03-23T18:16:01Z", "author_association": "OWNER", "body": "https://github.com/simonw/datasette/releases/tag/0.61\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1174423568, "label": "Ship Datasette 0.61"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1670#issuecomment-1076666293", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1670", "id": 1076666293, "node_id": "IC_kwDOBm6k_c5ALJ-1", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-23T18:16:29Z", "updated_at": "2022-03-23T18:16:29Z", "author_association": "OWNER", "body": "https://docs.datasette.io/en/stable/changelog.html#v0-61", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1174423568, "label": "Ship Datasette 0.61"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1670#issuecomment-1076683297", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1670", "id": 1076683297, "node_id": "IC_kwDOBm6k_c5ALOIh", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-23T18:32:32Z", "updated_at": "2022-03-23T18:32:32Z", "author_association": "OWNER", "body": "Added this to news on https://datasette.io/ https://github.com/simonw/datasette.io/commit/fd3ec57cdd5b935f75cbf52a86b3aabf2c97d217", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1174423568, "label": "Ship Datasette 0.61"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1682#issuecomment-1076696791", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1682", "id": 1076696791, "node_id": "IC_kwDOBm6k_c5ALRbX", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-23T18:45:49Z", "updated_at": "2022-03-23T18:45:49Z", "author_association": "OWNER", "body": "The problem is here in `QueryView`: https://github.com/simonw/datasette/blob/d7c793d7998388d915f8d270079c68a77a785051/datasette/views/database.py#L206-L238\r\n\r\nIt should be resolving `database` based on the route path, as seen in other methods like this one: https://github.com/simonw/datasette/blob/d7c793d7998388d915f8d270079c68a77a785051/datasette/views/table.py#L270-L279\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1178521513, "label": "SQL queries against databases with different routes are broken"}, "performed_via_github_app": null}