{"html_url": "https://github.com/simonw/datasette/issues/231#issuecomment-412291395", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/231", "id": 412291395, "node_id": "MDEyOklzc3VlQ29tbWVudDQxMjI5MTM5NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-08-11T17:54:41Z", "updated_at": "2018-08-11T17:54:41Z", "author_association": "OWNER", "body": "I'm going to separate the issue of enabling and disabling plugins from the existence of the `plugins` key. The format will simply be:\r\n\r\n```\r\n{\r\n    \"plugins\": {\r\n        \"name-of-plugin\": {\r\n            ... any structures you like go here, defined by the plugin ...\r\n        }\r\n    }\r\n}\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 316323336, "label": "metadata.json support for plugin configuration options"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/185#issuecomment-412299013", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/185", "id": 412299013, "node_id": "MDEyOklzc3VlQ29tbWVudDQxMjI5OTAxMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-08-11T20:14:54Z", "updated_at": "2018-08-11T20:14:54Z", "author_association": "OWNER", "body": "I've been worrying about how this one relates to #260 - I'd like to validate metadata (to help protect against people e.g. misspelling `license_url` and then being confused when their license isn't displayed properly), but this issue requests the ability to add arbitrary additional keys to the metadata structure.\r\n\r\nI think the solution is to introduce a metadata key called `extra_metadata_keys` which allows you to specifically list the extra keys that you want to enable. Something like this:\r\n\r\n```\r\n{\r\n    \"title\": \"My title\",\r\n    \"source\": \"Source\",\r\n    \"source_url\": \"https://www.example.com/\",\r\n    \"release_date\": \"2018-04-01\",\r\n    \"extra_metadata_keys\": [\"release_date\"]\r\n}\r\n```\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 299760684, "label": "Metadata should be a nested arbitrary KV store"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/238#issuecomment-412291437", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/238", "id": 412291437, "node_id": "MDEyOklzc3VlQ29tbWVudDQxMjI5MTQzNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-08-11T17:55:26Z", "updated_at": "2018-08-11T18:02:48Z", "author_association": "OWNER", "body": "On further thought, I'd much rather implement this using some kind of metadata plugin hook - see #357", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 317714268, "label": "External metadata.json"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/188#issuecomment-412291327", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/188", "id": 412291327, "node_id": "MDEyOklzc3VlQ29tbWVudDQxMjI5MTMyNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-08-11T17:53:17Z", "updated_at": "2018-08-11T17:53:17Z", "author_association": "OWNER", "body": "Potential problem: the existing `metadata.json` format looks like this:\r\n\r\n```\r\n{\r\n    \"title\": \"Custom title for your index page\",\r\n    \"description\": \"Some description text can go here\",\r\n    \"license\": \"ODbL\",\r\n    \"license_url\": \"https://opendatacommons.org/licenses/odbl/\",\r\n    \"databases\": {\r\n        \"database1\": {\r\n            \"source\": \"Alternative source\",\r\n            \"source_url\": \"http://example.com/\",\r\n            \"tables\": {\r\n                \"example_table\": {\r\n                    \"description_html\": \"Custom <em>table</em> description\",\r\n                    \"license\": \"CC BY 3.0 US\",\r\n                    \"license_url\": \"https://creativecommons.org/licenses/by/3.0/us/\"\r\n                }\r\n            }\r\n        }\r\n    }\r\n}\r\n```\r\n\r\nThis doesn't make sense for metadata that is bundled with a specific database - there's no point in having the `databases` key, instead the content of `database1` in the above example should be at the top level. This also means that if you rename the `*.db` file you won't have to edit its metadata at the same time.\r\n\r\nCalling such an embedded file `metadata.json` when the shape is different could be confusing. Maybe call it `database-metadata.json` instead.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 309047460, "label": "Ability to bundle metadata and templates inside the SQLite file"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/174#issuecomment-412290986", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/174", "id": 412290986, "node_id": "MDEyOklzc3VlQ29tbWVudDQxMjI5MDk4Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-08-11T17:46:51Z", "updated_at": "2018-08-11T17:46:51Z", "author_association": "OWNER", "body": "This was fixed in https://github.com/simonw/datasette/commit/89d9fbb91bfc0dd9091b34dbf3cf540ab849cc44", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 281197863, "label": "License/Source in footer should inherit from top level"}, "performed_via_github_app": null}