{"html_url": "https://github.com/simonw/datasette/issues/1971#issuecomment-1368266904", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1971", "id": 1368266904, "node_id": "IC_kwDOBm6k_c5RjhiY", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-31T19:09:48Z", "updated_at": "2022-12-31T19:09:48Z", "author_association": "OWNER", "body": "For the moment I'm going to pin to Sphinx 5.3.0\r\n\r\nNote that I got this warning there:\r\n\r\n```\r\n[sphinx-autobuild] > sphinx-build -b html /Users/simon/Dropbox/Development/datasette/docs /Users/simon/Dropbox/Development/datasette/docs/_build\r\nRunning Sphinx v5.3.0\r\nloading pickled environment... done\r\nWARNING: extlinks: Sphinx-6.0 will require a caption string to contain exactly one '%s' and all other '%' need to be escaped as '%%'.\r\n```\r\nSo I should probably fix that in advance of the 6.0 upgrade.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1515185383, "label": "Upgrade for Sphinx 6.0 (once Furo has support for it)"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/782#issuecomment-1368269811", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/782", "id": 1368269811, "node_id": "IC_kwDOBm6k_c5RjiPz", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-31T19:33:09Z", "updated_at": "2022-12-31T19:33:09Z", "author_association": "OWNER", "body": "Here's the so-far updated documentation for this change: https://github.com/simonw/datasette/blob/a2dca62360ad4a961d4c46f68eae41b7d5c7b2c9/docs/json_api.rst#different-shapes", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 627794879, "label": "Redesign default .json format"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/782#issuecomment-1368278278", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/782", "id": 1368278278, "node_id": "IC_kwDOBm6k_c5RjkUG", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-31T20:49:38Z", "updated_at": "2022-12-31T20:49:38Z", "author_association": "OWNER", "body": "I'm going to rename `filtered_table_rows_count` to `count` - to match the SQL `count(*)` function.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 627794879, "label": "Redesign default .json format"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/782#issuecomment-1368268148", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/782", "id": 1368268148, "node_id": "IC_kwDOBm6k_c5Rjh10", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-31T19:22:07Z", "updated_at": "2022-12-31T19:22:07Z", "author_association": "OWNER", "body": "It turned out the most significant part of this change - switching from an array of arrays to an array of objects for the `\"rows\"` key - was really easy: Datasette already had a `?_shape=arrays` v.s. `?_shape=objects` mechanism, so I switched which one was the default in https://github.com/simonw/datasette/commit/234230e59574ccb8d8a24c45ccd325f725812377", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 627794879, "label": "Redesign default .json format"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1966#issuecomment-1368267406", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1966", "id": 1368267406, "node_id": "IC_kwDOBm6k_c5RjhqO", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-31T19:15:10Z", "updated_at": "2022-12-31T19:15:10Z", "author_association": "OWNER", "body": "It's working again now - not sure what happened there, I was paying for Heroku for that already.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1501900064, "label": "Broken link to live demo in Getting started docs"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1967#issuecomment-1368267484", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1967", "id": 1368267484, "node_id": "IC_kwDOBm6k_c5Rjhrc", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-31T19:15:50Z", "updated_at": "2022-12-31T19:15:50Z", "author_association": "OWNER", "body": "My Firefox tab before:\r\n\r\n\"image\"\r\n\r\nAnd after:\r\n\r\n\"image\"\r\n", "reactions": "{\"total_count\": 1, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 1, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1503010009, "label": "Add favicon to documentation"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1971#issuecomment-1368266457", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1971", "id": 1368266457, "node_id": "IC_kwDOBm6k_c5RjhbZ", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-31T19:05:26Z", "updated_at": "2022-12-31T19:05:26Z", "author_association": "OWNER", "body": "Ran this locally:\r\n\r\n pip install -U Sphinx\r\n\r\nGot these warnings:\r\n\r\n```\r\nInstalling collected packages: Sphinx\r\n Attempting uninstall: Sphinx\r\n Found existing installation: Sphinx 5.1.1\r\n Uninstalling Sphinx-5.1.1:\r\n Successfully uninstalled Sphinx-5.1.1\r\nERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.\r\nsphinx-basic-ng 0.0.1a12 requires sphinx<6.0,>=4.0, but you have sphinx 6.0.0 which is incompatible.\r\nfuro 2022.6.21 requires sphinx<6.0,>=4.0, but you have sphinx 6.0.0 which is incompatible.\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1515185383, "label": "Upgrade for Sphinx 6.0 (once Furo has support for it)"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1970#issuecomment-1368264882", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1970", "id": 1368264882, "node_id": "IC_kwDOBm6k_c5RjhCy", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-31T18:52:01Z", "updated_at": "2022-12-31T18:52:01Z", "author_association": "OWNER", "body": "Relevant code: https://github.com/simonw/datasette/blob/e03aed00026cc2e59c09ca41f69a247e1a85cc89/datasette/app.py#L418-L424", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1515182998, "label": "Path \"None\" in _internal database table"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1971#issuecomment-1368266658", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1971", "id": 1368266658, "node_id": "IC_kwDOBm6k_c5Rjhei", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-31T19:07:19Z", "updated_at": "2022-12-31T19:07:19Z", "author_association": "OWNER", "body": "So it looks like Furo doesn't work with Sphinx 6.0 yet - there' s a fix on `main` but it hasn't been released:\r\n\r\n- https://github.com/pradyunsg/furo/discussions/569", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1515185383, "label": "Upgrade for Sphinx 6.0 (once Furo has support for it)"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1967#issuecomment-1368265354", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1967", "id": 1368265354, "node_id": "IC_kwDOBm6k_c5RjhKK", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-31T18:56:35Z", "updated_at": "2022-12-31T18:56:35Z", "author_association": "OWNER", "body": "Thanks for this!\r\n\r\nDatasette has a favicon in this file: https://github.com/simonw/datasette/blob/2b4a8aa0833068da25072b6247bf349949ca00ee/datasette/static/favicon.png - so I'll copy that over and use it here as well.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1503010009, "label": "Add favicon to documentation"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1970#issuecomment-1368268233", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1970", "id": 1368268233, "node_id": "IC_kwDOBm6k_c5Rjh3J", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-31T19:22:58Z", "updated_at": "2022-12-31T19:22:58Z", "author_association": "OWNER", "body": "https://latest.datasette.io/_internal/databases shows the fix now:\r\n\r\n\"image\"\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1515182998, "label": "Path \"None\" in _internal database table"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/782#issuecomment-1368285442", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/782", "id": 1368285442, "node_id": "IC_kwDOBm6k_c5RjmEC", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-31T22:02:16Z", "updated_at": "2022-12-31T22:02:16Z", "author_association": "OWNER", "body": "https://latest.datasette.io/fixtures/compound_three_primary_keys.json?_size=2 now returns `count`:\r\n\r\n```json\r\n{\r\n \"database\": \"fixtures\",\r\n \"table\": \"compound_three_primary_keys\",\r\n \"is_view\": false,\r\n \"human_description_en\": \"\",\r\n \"rows\": [\r\n {\r\n \"pk1\": \"a\",\r\n \"pk2\": \"a\",\r\n \"pk3\": \"a\",\r\n \"content\": \"a-a-a\"\r\n },\r\n {\r\n \"pk1\": \"a\",\r\n \"pk2\": \"a\",\r\n \"pk3\": \"b\",\r\n \"content\": \"a-a-b\"\r\n }\r\n ],\r\n \"truncated\": false,\r\n \"count\": 1001,\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 627794879, "label": "Redesign default .json format"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/782#issuecomment-1368269283", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/782", "id": 1368269283, "node_id": "IC_kwDOBm6k_c5RjiHj", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-12-31T19:29:45Z", "updated_at": "2022-12-31T19:29:45Z", "author_association": "OWNER", "body": "https://latest.datasette.io/fixtures/compound_three_primary_keys.json?_size=2 now shows the new default:\r\n```json\r\n{\r\n \"database\": \"fixtures\",\r\n \"table\": \"compound_three_primary_keys\",\r\n \"is_view\": false,\r\n \"human_description_en\": \"\",\r\n \"rows\": [\r\n {\r\n \"pk1\": \"a\",\r\n \"pk2\": \"a\",\r\n \"pk3\": \"a\",\r\n \"content\": \"a-a-a\"\r\n },\r\n {\r\n \"pk1\": \"a\",\r\n \"pk2\": \"a\",\r\n \"pk3\": \"b\",\r\n \"content\": \"a-a-b\"\r\n }\r\n ],\r\n```\r\nThe old format can be had like this: https://latest.datasette.io/fixtures/compound_three_primary_keys.json?_size=2&_shape=arrays", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 627794879, "label": "Redesign default .json format"}, "performed_via_github_app": null}