{"html_url": "https://github.com/simonw/datasette/issues/276#issuecomment-391050113", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/276", "id": 391050113, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTA1MDExMw==", "user": {"value": 45057, "label": "russss"}, "created_at": "2018-05-22T16:13:00Z", "updated_at": "2018-05-22T16:13:00Z", "author_association": "CONTRIBUTOR", "body": "Yup, I'll have a think about it. My current thoughts are for spatialite we'll need to hook into the following places:\r\n\r\n* Inspection, so we can detect which columns are geometry columns. (We also currently ignore spatialite tables during inspection, it may be worth moving that to the plugin as well.)\r\n* After data load, so we can convert WKB into the correct intermediate format for display. The alternative here is to alter the select SQL itself and get spatialite to do this conversion, but that strikes me as a bit more complex and possibly not as useful.\r\n* HTML rendering.\r\n* Querying?\r\n\r\nThe rendering and querying hooks could also potentially be used to move the units support into a plugin.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 324835838, "label": "Handle spatialite geometry columns better"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/280#issuecomment-391059008", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/280", "id": 391059008, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTA1OTAwOA==", "user": {"value": 565628, "label": "r4vi"}, "created_at": "2018-05-22T16:40:27Z", "updated_at": "2018-05-22T16:40:27Z", "author_association": "CONTRIBUTOR", "body": "```python\r\n>>> import sqlite3\r\n>>> sqlite3.sqlite_version\r\n'3.23.1'\r\n>>> \r\n```\r\nrunning the above in the container seems to show 3.23.1 too so maybe we don't need pysqlite3 at all?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325373747, "label": "Build Dockerfile with recent Sqlite + Spatialite"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/279#issuecomment-391073009", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/279", "id": 391073009, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTA3MzAwOQ==", "user": {"value": 198537, "label": "rgieseke"}, "created_at": "2018-05-22T17:23:26Z", "updated_at": "2018-05-22T17:23:26Z", "author_association": "CONTRIBUTOR", "body": "> I think I prefer the aesthetics of just \"0.22\" for the version string if it's a tagged release with no additional changes - does that work?\r\n\r\nYes! That's the default versioneer behaviour.\r\n\r\n> I'd like to continue to provide a tuple that can be imported from the version.py module as well, as seen here:\r\n\r\nShould work now, it can be a two (for a tagged version), three or four items tuple.\r\n\r\n```\r\nIn [2]: datasette.__version__\r\nOut[2]: '0.12+292.ga70c2a8.dirty'\r\n\r\nIn [3]: datasette.__version_info__\r\nOut[3]: ('0', '12+292', 'ga70c2a8', 'dirty')\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325352370, "label": "Add version number support with Versioneer"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/279#issuecomment-391073267", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/279", "id": 391073267, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTA3MzI2Nw==", "user": {"value": 198537, "label": "rgieseke"}, "created_at": "2018-05-22T17:24:16Z", "updated_at": "2018-05-22T17:24:16Z", "author_association": "CONTRIBUTOR", "body": "Sorry, just realised you rely on `version` being a module ...", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325352370, "label": "Add version number support with Versioneer"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/279#issuecomment-391077700", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/279", "id": 391077700, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTA3NzcwMA==", "user": {"value": 198537, "label": "rgieseke"}, "created_at": "2018-05-22T17:38:17Z", "updated_at": "2018-05-22T17:38:17Z", "author_association": "CONTRIBUTOR", "body": "Alright, that should work now -- let me know if you would prefer any different behaviour.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325352370, "label": "Add version number support with Versioneer"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/280#issuecomment-391141391", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/280", "id": 391141391, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MTE0MTM5MQ==", "user": {"value": 565628, "label": "r4vi"}, "created_at": "2018-05-22T21:08:39Z", "updated_at": "2018-05-22T21:08:39Z", "author_association": "CONTRIBUTOR", "body": "I'm going to clean this up for consistency tomorrow morning so hold off\nmerging until then please\n\nOn Tue, May 22, 2018 at 6:34 PM, Simon Willison <notifications@github.com>\nwrote:\n\n> Yeah let's try this without pysqlite3 and see if we still get the correct\n> version.\n>\n> \u2014\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/simonw/datasette/pull/280#issuecomment-391076458>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AAihfMI-H6CBt-Py0xdBbH2xDK0KsjT2ks5t1EwYgaJpZM4UI_2m>\n> .\n>\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 325373747, "label": "Build Dockerfile with recent Sqlite + Spatialite"}, "performed_via_github_app": null}