{"html_url": "https://github.com/simonw/datasette/issues/537#issuecomment-512664216", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/537", "id": 512664216, "node_id": "MDEyOklzc3VlQ29tbWVudDUxMjY2NDIxNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-07-18T04:53:18Z", "updated_at": "2019-07-18T04:53:18Z", "author_association": "OWNER", "body": "Yes, `TableView` is desirable here I think. Maybe `datasette.views.table.TableView` if we can get that somehow. Thanks for taking a look!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 463544206, "label": "Populate \"endpoint\" key in ASGI scope"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/537#issuecomment-512930353", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/537", "id": 512930353, "node_id": "MDEyOklzc3VlQ29tbWVudDUxMjkzMDM1Mw==", "user": {"value": 14834132, "label": "SteadBytes"}, "created_at": "2019-07-18T18:20:53Z", "updated_at": "2019-07-18T18:34:03Z", "author_association": "NONE", "body": "Ok great, getting the `__qualname__` to be `TableView` and adding `endpoint` to the `scope` in `AsgiRouter` is simple enough (already done). However, (unless I'm missing a plugin hook or something) the suggestion of utilising it within a `datasette-sentry` plugin may not work. The only hook that would have access to the `scope` is the `asgi_wrapper` hook. But as this _wraps_ the existing `asgi` app, the `endpoint` won't yet have been added to the `scope` received by the hook https://github.com/SteadBytes/datasette/blob/107d47567dedd472eebec7f35bc34f5b58285ba8/datasette/app.py#L672 . However, I'm not sure where else the `endpoint` could be added to the asgi scope :thinking: \r\n\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 463544206, "label": "Populate \"endpoint\" key in ASGI scope"}, "performed_via_github_app": null}