{"html_url": "https://github.com/simonw/sqlite-utils/issues/81#issuecomment-581071010", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/81", "id": 581071010, "node_id": "MDEyOklzc3VlQ29tbWVudDU4MTA3MTAxMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-02-01T21:27:00Z", "updated_at": "2020-02-01T21:27:00Z", "author_association": "OWNER", "body": "Here's the current method:\r\n\r\nhttps://github.com/simonw/sqlite-utils/blob/f7289174e66ae4d91d57de94bbd9d09fabf7aff4/sqlite_utils/db.py#L823-L845\r\n\r\nIf I make it a utility function instead of a class method I could ensure it is directly importable like so:\r\n\r\n```python\r\nfrom sqlite_utils import detect_column_types\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 558600274, "label": "Remove .detect_column_types() from table, make it a documented API"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/81#issuecomment-581071116", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/81", "id": 581071116, "node_id": "MDEyOklzc3VlQ29tbWVudDU4MTA3MTExNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-02-01T21:28:35Z", "updated_at": "2020-02-01T21:28:53Z", "author_association": "OWNER", "body": "Should I keep `table.detect_column_types()` working so as not to break existing code?\r\n\r\nIf it was part of the documented API then I wouldn't break that without bumping to 3.x. Since it's undocumented I'm going to make it as a breaking change instead (and bump the `geojson-to-sqlite` dependency version).", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 558600274, "label": "Remove .detect_column_types() from table, make it a documented API"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/81#issuecomment-581071235", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/81", "id": 581071235, "node_id": "MDEyOklzc3VlQ29tbWVudDU4MTA3MTIzNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-02-01T21:30:09Z", "updated_at": "2020-02-01T21:30:09Z", "author_association": "OWNER", "body": "Actually I'll put it in the `utils.py` module.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 558600274, "label": "Remove .detect_column_types() from table, make it a documented API"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/81#issuecomment-581071434", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/81", "id": 581071434, "node_id": "MDEyOklzc3VlQ29tbWVudDU4MTA3MTQzNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-02-01T21:32:34Z", "updated_at": "2020-02-01T21:32:34Z", "author_association": "OWNER", "body": "While I'm at it I think I'll rename it to `suggest_column_types` - it's not really detecting them since the input is just a list of dictionaries.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 558600274, "label": "Remove .detect_column_types() from table, make it a documented API"}, "performed_via_github_app": null}