{"html_url": "https://github.com/simonw/datasette/issues/984#issuecomment-701708072", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/984", "id": 701708072, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTcwODA3Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-01T00:01:36Z", "updated_at": "2020-10-01T00:01:36Z", "author_association": "OWNER", "body": "Column action menus are the cog icons on https://latest.datasette.io/fixtures/facetable", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 712368432, "label": "Review accessibility of new column action menus"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/530#issuecomment-701720034", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/530", "id": 701720034, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMTcyMDAzNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-01T00:42:08Z", "updated_at": "2020-10-01T00:42:08Z", "author_association": "OWNER", "body": "I've changed my mind - especially since Datasette now ships with default JavaScript for the column menus in #981. I'm not going to extract CodeMirror into a plugin, I'll leave it where it is.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 460540321, "label": "Extract codemirror SQL editor out into a plugin"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/986#issuecomment-702171636", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/986", "id": 702171636, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMjE3MTYzNg==", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2020-10-01T14:24:11Z", "updated_at": "2020-10-01T14:24:11Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/986?src=pr&el=h1) Report\n> Merging [#986](https://codecov.io/gh/simonw/datasette/pull/986?src=pr&el=desc) into [main](https://codecov.io/gh/simonw/datasette/commit/141544613f9e76ddb74eee38d6f8ee1e0e70f833?el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/986/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1)](https://codecov.io/gh/simonw/datasette/pull/986?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## main #986 +/- ##\n=======================================\n Coverage 84.28% 84.28% \n=======================================\n Files 28 28 \n Lines 3850 3850 \n=======================================\n Hits 3245 3245 \n Misses 605 605 \n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/986?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `\u0394 = absolute (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/986?src=pr&el=footer). Last update [1415446...76f7094](https://codecov.io/gh/simonw/datasette/pull/986?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 712889459, "label": "Allow facet by primary keys, fixes #985"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/985#issuecomment-702132019", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/985", "id": 702132019, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMjEzMjAxOQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-01T13:23:48Z", "updated_at": "2020-10-01T13:23:48Z", "author_association": "OWNER", "body": "The code that skips the \"facet by this\" menu option for primary key columns could take into account if there are multiple primary keys.\r\n\r\nhttps://github.com/simonw/datasette/blob/141544613f9e76ddb74eee38d6f8ee1e0e70f833/datasette/static/table.js#L91-L98", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 712839383, "label": "Column actions should support facet by compound primary keys"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/987#issuecomment-702240916", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/987", "id": 702240916, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMjI0MDkxNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-01T16:10:44Z", "updated_at": "2020-10-01T16:10:44Z", "author_association": "OWNER", "body": "https://github.com/simonw/datasette/blob/141544613f9e76ddb74eee38d6f8ee1e0e70f833/datasette/templates/_table.html#L6", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 712984738, "label": "Documented HTML hooks for JavaScript plugin authors"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/987#issuecomment-702241397", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/987", "id": 702241397, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMjI0MTM5Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-01T16:11:31Z", "updated_at": "2020-10-01T16:11:31Z", "author_association": "OWNER", "body": "This should be a new page in the documentation, which will be expanded later on to cover things like the proposed JavaScript plugin hooks system from #983.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 712984738, "label": "Documented HTML hooks for JavaScript plugin authors"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/986#issuecomment-702265255", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/986", "id": 702265255, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMjI2NTI1NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-01T16:51:45Z", "updated_at": "2020-10-01T16:51:45Z", "author_association": "OWNER", "body": "Thanks for taking a look! The fix ended up being a little different from this because I still want to disable faceting on regular single primary keys (since faceting by those won't ever produce interesting results) - here's what I used: https://github.com/simonw/datasette/commit/5d6bc4c268f9f155e59561671f8617addd3e91bc", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 712889459, "label": "Allow facet by primary keys, fixes #985"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/865#issuecomment-702418045", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/865", "id": 702418045, "node_id": "MDEyOklzc3VlQ29tbWVudDcwMjQxODA0NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-01T21:54:00Z", "updated_at": "2020-10-01T21:54:00Z", "author_association": "OWNER", "body": "Had a thought: this is likely to break in plugins too, such as `datasette-edit-schema` which constructs URLs for redirects e.g. here: https://github.com/simonw/datasette-edit-schema/blob/dbd0abee6dd3385b114cfe9671f7ead1c4855b60/datasette_edit_schema/__init__.py#L46-L48", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 644582921, "label": "base_url doesn't seem to work when adding criteria and clicking \"apply\""}, "performed_via_github_app": null}