{"html_url": "https://github.com/simonw/datasette/issues/996#issuecomment-705115185", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/996", "id": 705115185, "node_id": "MDEyOklzc3VlQ29tbWVudDcwNTExNTE4NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-07T18:26:11Z", "updated_at": "2020-10-07T18:26:45Z", "author_association": "OWNER", "body": "Relevant code: https://github.com/simonw/datasette/blob/14982bd900f17a66acc3930ec1a2ff138716d198/datasette/app.py#L1030-L1037\r\n\r\nhttps://github.com/simonw/datasette/blob/14982bd900f17a66acc3930ec1a2ff138716d198/datasette/app.py#L951-L954\r\n\r\nhttps://github.com/simonw/datasette/blob/14982bd900f17a66acc3930ec1a2ff138716d198/datasette/app.py#L1197-L1207", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 716756082, "label": "Better handling of multiple matching template wildcard paths"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/996#issuecomment-705116123", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/996", "id": 705116123, "node_id": "MDEyOklzc3VlQ29tbWVudDcwNTExNjEyMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-07T18:27:57Z", "updated_at": "2020-10-07T18:28:36Z", "author_association": "OWNER", "body": "This line was meant to handle this case, by only matching non-/ characters. Looks like it did not have the desired effect: https://github.com/simonw/datasette/blob/14982bd900f17a66acc3930ec1a2ff138716d198/datasette/app.py#L1204\r\n\r\nMaybe because the finished regex doesn't include `^` and `$` anchors?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 716756082, "label": "Better handling of multiple matching template wildcard paths"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/996#issuecomment-705119801", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/996", "id": 705119801, "node_id": "MDEyOklzc3VlQ29tbWVudDcwNTExOTgwMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-07T18:34:58Z", "updated_at": "2020-10-07T18:34:58Z", "author_association": "OWNER", "body": "One option: compare the length of the matches and pick the shortest one.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 716756082, "label": "Better handling of multiple matching template wildcard paths"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/991#issuecomment-705244583", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/991", "id": 705244583, "node_id": "MDEyOklzc3VlQ29tbWVudDcwNTI0NDU4Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-07T23:24:56Z", "updated_at": "2020-10-07T23:24:56Z", "author_association": "OWNER", "body": "Sketched out an option:\r\n```diff\r\ndiff --git a/datasette/templates/index.html b/datasette/templates/index.html\r\nindex c1adfc5..eab3053 100644\r\n--- a/datasette/templates/index.html\r\n+++ b/datasette/templates/index.html\r\n@@ -5,6 +5,14 @@\r\n {% block body_class %}index{% endblock %}\r\n \r\n {% block content %}\r\n+<style>\r\n+.db-table {\r\n+    padding-left: 2em;\r\n+}\r\n+.db-table h3 {\r\n+    margin: 0 0 0.15em 0;\r\n+}\r\n+</style>\r\n <h1>{{ metadata.title or \"Datasette\" }}{% if private %} \ud83d\udd12{% endif %}</h1>\r\n \r\n {% block description_source_license %}{% include \"_description_source_license.html\" %}{% endblock %}\r\n@@ -21,8 +29,20 @@\r\n             {{ \"{:,}\".format(database.views_count) }} view{% if database.views_count != 1 %}s{% endif %}\r\n         {% endif %}\r\n     </p>\r\n-    <p>{% for table in database.tables_and_views_truncated %}<a href=\"{{ database.path }}/{{ table.name|quote_plus \r\n-    }}\"{% if table.count %} title=\"{{ table.count }} rows\"{% endif %}>{{ table.name }}</a>{% if table.private %} \ud83d\udd12{% endif %}{% if not loop.last %}, {% endif %}{% endfor %}{% if database.tables_and_views_more %}, <a href=\"{{ database.path }}\">...</a>{% endif %}</p>\r\n+    {% for table in database.tables_and_views_truncated %}\r\n+        {% if show_hidden or not table.hidden %}\r\n+        <div class=\"db-table\">\r\n+            <h3><a href=\"{{ database_url(database.name) }}/{{ table.name|quote_plus }}\">{{ table.name }}</a>{% if table.private %} \ud83d\udd12{% endif %}{% if table.hidden %}<em> (hidden)</em>{% endif %}</h3>\r\n+            <p><em>{% for column in table.columns[:9] %}{{ column }}{% if not loop.last %}, {% endif %}{% endfor %}{% if table.columns|length > 9 %}...{% endif %}</em></p>\r\n+            <p>{% if table.count is none %}Many rows{% else %}{{ \"{:,}\".format(table.count) }} row{% if table.count == 1 %}{% else %}s{% endif %}{% endif %}</p>\r\n+        </div>\r\n+        {% endif %}\r\n+    {% endfor %}\r\n+\r\n+    {% if database.tables_and_views_more %}\r\n+        <p><a href=\"{{ database.path }}\">All {{ database.tables_count }} tables in {{ database.name }}</a></p>\r\n+    {% endif %}\r\n+\r\n {% endfor %}\r\n \r\n {% endblock %}\r\n```\r\n\r\n![image](https://user-images.githubusercontent.com/9599/95398019-9c594480-08b9-11eb-90c9-f322d647ee3b.png)\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 714377268, "label": "Redesign application homepage"}, "performed_via_github_app": null}