{"html_url": "https://github.com/simonw/datasette/issues/998#issuecomment-714090965", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/998", "id": 714090965, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNDA5MDk2NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-22T00:54:30Z", "updated_at": "2020-10-22T00:54:30Z", "author_association": "OWNER", "body": "Easiest fix for the column action menu positioning - hide them when the user scrolls the containing div:\r\n```javascript\r\ndocument.querySelector('.table-wrapper').addEventListener(\r\n 'scroll', () => document.querySelector('.dropdown-menu').style.display = 'none'\r\n); \r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 717699884, "label": "Wide tables should scroll horizontally within the page"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/998#issuecomment-714092002", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/998", "id": 714092002, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNDA5MjAwMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-22T00:55:10Z", "updated_at": "2020-10-22T00:55:10Z", "author_association": "OWNER", "body": "This isn't blocked on #987 - it just means that `datasette-cluster-map` will need to learn to look for `.table-wrapper` first and fall back on the table.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 717699884, "label": "Wide tables should scroll horizontally within the page"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/998#issuecomment-714117534", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/998", "id": 714117534, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNDExNzUzNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-22T01:12:06Z", "updated_at": "2020-10-22T01:12:06Z", "author_association": "OWNER", "body": "Demo:\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 717699884, "label": "Wide tables should scroll horizontally within the page"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1031#issuecomment-714289680", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1031", "id": 714289680, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNDI4OTY4MA==", "user": {"value": 299380, "label": "frankier"}, "created_at": "2020-10-22T07:23:52Z", "updated_at": "2020-10-22T07:23:52Z", "author_association": "NONE", "body": "The bug is that currently when there are databases passed in, but no -i flag, e.g. in configuration directory mode, inclusion in inspect-data.json does not automatically cause databases to be considered immutable, as described in the documentation.\r\n\r\nThe reason is that the -i flag is specified multiple=True, which means when it is not passed in we will get an empty list [], rather than None. So the current code decides that no databases are immutable rather than falling back to inspect-data.json -- as is presumably intended.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 724369025, "label": "Fallback to databases in inspect-data.json when no -i options are passed"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/998#issuecomment-714205783", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/998", "id": 714205783, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNDIwNTc4Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-22T03:58:13Z", "updated_at": "2020-10-22T03:58:13Z", "author_association": "OWNER", "body": "This is now live here: https://global-power-plants.datasettes.com/global-power-plants/global-power-plants", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 717699884, "label": "Wide tables should scroll horizontally within the page"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1040#issuecomment-714206533", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1040", "id": 714206533, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNDIwNjUzMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-22T04:00:25Z", "updated_at": "2020-10-22T04:00:25Z", "author_association": "OWNER", "body": "I've decided not to offer a configuration option to turn this off. I'll reconsider if someone asks for it.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 726910999, "label": "/db/table/-/blob/pk/column.blob download URL"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1031#issuecomment-714206875", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1031", "id": 714206875, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNDIwNjg3NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-22T04:01:19Z", "updated_at": "2020-10-22T04:01:19Z", "author_association": "OWNER", "body": "I don't fully understand the bug you're fixing here. Could you provide a bit more explanation?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 724369025, "label": "Fallback to databases in inspect-data.json when no -i options are passed"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/171#issuecomment-714208848", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/171", "id": 714208848, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNDIwODg0OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-22T04:07:14Z", "updated_at": "2020-10-22T04:07:14Z", "author_association": "OWNER", "body": "I made the `--load-extension` command much more widely supported in #137 - which should be useful for anyone who wants to use this extension.\r\n\r\nIt's a bit too obscure for me to want to add direct Python library support relating to that extension though.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 707407567, "label": "Idea: transitive closure tables for tree structures"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/171#issuecomment-714219725", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/171", "id": 714219725, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNDIxOTcyNQ==", "user": {"value": 649467, "label": "mhalle"}, "created_at": "2020-10-22T04:38:35Z", "updated_at": "2020-10-22T04:38:35Z", "author_association": "NONE", "body": "Thanks. As I said, I think the result (being able to query tree structures like ancestors and descendants) is more important than the implementation, and I agree that this particular sqlite extension is too obscure. Just providing an sqlite utility to build or rebuild a transitive closure table might be more generically useful. I find that hierarchical data shows up pretty frequently in some data science problems.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 707407567, "label": "Idea: transitive closure tables for tree structures"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1033#issuecomment-714657366", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1033", "id": 714657366, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNDY1NzM2Ng==", "user": {"value": 82988, "label": "psychemedia"}, "created_at": "2020-10-22T17:51:29Z", "updated_at": "2020-10-22T17:51:29Z", "author_association": "CONTRIBUTOR", "body": "How does `/-/static` relate to [current guidance docs around `static`](https://docs.datasette.io/en/latest/custom_templates.html?highlight=static#serving-static-files) regarding the `--static option` and metadata formulations such as `\"extra_js_urls\": [ \"/static/app.js\"]` (I've not managed to get this to work in a Jupyter server proxied set up; the [datasette / jupyter server proxy repo](https://github.com/simonw/jupyterserverproxy-datasette-demo) may provide a useful test example, eg via MyBinder, for folk to crib from?) ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 725099777, "label": "datasette.urls.static_plugins(...) method"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1033#issuecomment-714681365", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1033", "id": 714681365, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNDY4MTM2NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-22T18:33:48Z", "updated_at": "2020-10-22T18:33:48Z", "author_association": "OWNER", "body": "That's a good question - I hadn't considered that. I'm going to open a new issue to have `extra_js_urls` respect the `base_url` setting, since the static files will be served from a different location.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 725099777, "label": "datasette.urls.static_plugins(...) method"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1041#issuecomment-714682288", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1041", "id": 714682288, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNDY4MjI4OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-22T18:35:15Z", "updated_at": "2020-10-22T18:35:15Z", "author_association": "OWNER", "body": "@psychemedia said: https://github.com/simonw/datasette/issues/1033#issuecomment-714657366\r\n\r\n> How does `/-/static` relate to [current guidance docs around `static`](https://docs.datasette.io/en/latest/custom_templates.html?highlight=static#serving-static-files) regarding the `--static option` and metadata formulations such as `\"extra_js_urls\": [ \"/static/app.js\"]` (I've not managed to get this to work in a Jupyter server proxied set up; the [datasette / jupyter server proxy repo](https://github.com/simonw/jupyterserverproxy-datasette-demo) may provide a useful test example, eg via MyBinder, for folk to crib from?)", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 727627923, "label": "extra_js_urls and extra_css_urls should respect base_url setting"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1041#issuecomment-714682825", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1041", "id": 714682825, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNDY4MjgyNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-22T18:36:10Z", "updated_at": "2020-10-22T18:36:10Z", "author_association": "OWNER", "body": "I'll need to update these docs once there's a solution for this in place: https://docs.datasette.io/en/latest/custom_templates.html#serving-static-files", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 727627923, "label": "extra_js_urls and extra_css_urls should respect base_url setting"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1041#issuecomment-714683801", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1041", "id": 714683801, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNDY4MzgwMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-22T18:37:47Z", "updated_at": "2020-10-22T18:37:47Z", "author_association": "OWNER", "body": "I think I'll do this by looking for URLs that start with `/` - since it's also possible to have full `https://...` URLs in that setting.\r\n```json\r\n{\r\n \"extra_css_urls\": [\r\n \"/static/styles.css\"\r\n ],\r\n \"extra_js_urls\": [\r\n \"/static/app.js\"\r\n ]\r\n}\r\n```\r\nI need to think about the `extra_css_urls` and `extra_js_urls` plugin hooks too: https://docs.datasette.io/en/stable/plugin_hooks.html#extra-css-urls-template-database-table-columns-view-name-request-datasette", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 727627923, "label": "extra_js_urls and extra_css_urls should respect base_url setting"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/173#issuecomment-714758139", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/173", "id": 714758139, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNDc1ODEzOQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-22T20:57:56Z", "updated_at": "2020-10-22T20:57:56Z", "author_association": "OWNER", "body": "I could use `ijson` to provide a progress bar for JSON arrays too. I'd prefer to keep that as an optional dependency though, since `sqlite-utils` is a library dependency for many other projects and it would be using `ijson` purely for the CLI component.\r\n\r\nHere's how to iterate through a list of objects being read from a file:\r\n\r\n```python\r\nimport json\r\nparser = ijson.items(open(\r\n \"/tmp/list.json\"\r\n), \"item\")\r\nfor object in parser:\r\n # ...\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 707478649, "label": "Progress bar for sqlite-utils insert"}, "performed_via_github_app": null}