{"html_url": "https://github.com/simonw/datasette/issues/1468#issuecomment-917839801", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1468", "id": 917839801, "node_id": "IC_kwDOBm6k_c42tR-5", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-09-13T04:54:17Z", "updated_at": "2021-09-13T04:54:17Z", "author_association": "OWNER", "body": "Here's a already open issue for this: #972", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 994390593, "label": "Faceting for custom SQL queries"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1468#issuecomment-917839507", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1468", "id": 917839507, "node_id": "IC_kwDOBm6k_c42tR6T", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-09-13T04:53:22Z", "updated_at": "2021-09-13T04:53:22Z", "author_association": "OWNER", "body": "At the moment this isn't possible - though there's a workaround which is to define a SQL view for the query, at which point facets will be displayed again.\r\n\r\nI did a lot of the work required to support this when I refactored how facets worked a while back - but to finally implement this I need to refactor the table view and the arbitrary query view to share much more logic than they do at the moment.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 994390593, "label": "Faceting for custom SQL queries"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1469#issuecomment-917839062", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1469", "id": 917839062, "node_id": "IC_kwDOBm6k_c42tRzW", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-09-13T04:52:01Z", "updated_at": "2021-09-13T04:52:01Z", "author_association": "OWNER", "body": "Here's the code at fault: https://github.com/simonw/datasette/blob/b28b6cd2fe97f7e193a235877abeec2c8eb0a821/datasette/static/table.js#L137-L146", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 994450961, "label": "Column cog shows \"facet by this\" when already default faceted"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1466#issuecomment-917840012", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1466", "id": 917840012, "node_id": "IC_kwDOBm6k_c42tSCM", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-09-13T04:54:59Z", "updated_at": "2021-09-13T04:54:59Z", "author_association": "OWNER", "body": "Especially relevant now that 0.2.0 is out which is a much higher quality release. https://github.com/simonw/datasette-app/releases/tag/0.2.0", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 991467558, "label": "Add Datasette Desktop to installation documentation"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1464#issuecomment-918621705", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1464", "id": 918621705, "node_id": "IC_kwDOBm6k_c42wQ4J", "user": {"value": 7476523, "label": "bobwhitelock"}, "created_at": "2021-09-13T22:17:17Z", "updated_at": "2021-09-13T22:17:17Z", "author_association": "CONTRIBUTOR", "body": "> haven't had time to get back to this, but idle thought that I'm recording for later investigation: how does the continuous integration handle this installation issue? Is it documented there?\r\n\r\nNot certain, but I think tests in CI run on Ubuntu and don't appear to install any additional Sqlite-related dependencies, and so my guess is the version of Sqlite installed by default on Ubuntu has the `SQLITE_ENABLE_FTS3_PARENTHESIS` option enabled and so doesn't run into this issue.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 991191951, "label": "clean checkout & clean environment has test failures"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1385#issuecomment-869105782", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1385", "id": 869105782, "node_id": "MDEyOklzc3VlQ29tbWVudDg2OTEwNTc4Mg==", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2021-06-27T05:48:55Z", "updated_at": "2021-09-13T17:29:30Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/1385?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\n> Merging [#1385](https://codecov.io/gh/simonw/datasette/pull/1385?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (db78094) into [main](https://codecov.io/gh/simonw/datasette/commit/ea627baccf980d7d8ebc9e1ffff1fe34d556e56f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (ea627ba) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n> :exclamation: Current head db78094 differs from pull request most recent head 8d78c8c. Consider uploading reports for the commit 8d78c8c to get more accurate results\n[](https://codecov.io/gh/simonw/datasette/pull/1385?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n\n```diff\n@@ Coverage Diff @@\n## main #1385 +/- ##\n=======================================\n Coverage 91.70% 91.70% \n=======================================\n Files 34 34 \n Lines 4364 4364 \n=======================================\n Hits 4002 4002 \n Misses 362 362 \n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1385?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n> `\u0394 = absolute (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1385?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Last update [ea627ba...8d78c8c](https://codecov.io/gh/simonw/datasette/pull/1385?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 930855052, "label": "Fix + improve get_metadata plugin hook docs"}, "performed_via_github_app": null}