{"html_url": "https://github.com/simonw/datasette/issues/1784#issuecomment-1216042605", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1784", "id": 1216042605, "node_id": "IC_kwDOBm6k_c5Ie1Zt", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-08-16T01:28:46Z", "updated_at": "2022-08-16T01:28:46Z", "author_association": "OWNER", "body": "Do you want to write a PR for this?\r\n\r\nIdeally I'd want this to be covered by a test, but it looks like `--load-extension` isn't covered by tests at all yet. It's a tricky thing to add to the unit tests because there are plenty of Python installs out there (including the one on my Mac) that don't support `.enable_load_extension()` at all.\r\n\r\nSo maybe a test which uses `@pytest.mark.skipIf()` to skip itself if the environment it is running in doesn't support that feature?\r\n\r\nBut we'd also need to bundle a compiled SQLite extension to use in the test, which would be a slightly weird thing to have in the repo.\r\n\r\nWe do have one previous example of something like that though: https://github.com/simonw/datasette/blob/main/tests/spatialite.db and the script that builds it https://github.com/simonw/datasette/blob/main/tests/build_small_spatialite_db.py", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1339663518, "label": "Include \"entrypoint\" option on `--load-extension`?"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1784#issuecomment-1216035677", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1784", "id": 1216035677, "node_id": "IC_kwDOBm6k_c5Ieztd", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-08-16T01:13:18Z", "updated_at": "2022-08-16T01:13:32Z", "author_association": "OWNER", "body": "I didn't know SQLite could do this.\r\n\r\nI agree with you - I like the `:` option you described there.\r\n\r\nI'd like to stick with `--load-extension` - `--load` is general enough that I might have it do something else in the future, and this is a rare enough advanced feature that I'm OK with it being verbose.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1339663518, "label": "Include \"entrypoint\" option on `--load-extension`?"}, "performed_via_github_app": null}