{"html_url": "https://github.com/simonw/datasette/issues/849#issuecomment-667295759", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/849", "id": 667295759, "node_id": "MDEyOklzc3VlQ29tbWVudDY2NzI5NTc1OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-31T18:45:35Z", "updated_at": "2020-07-31T18:45:35Z", "author_association": "OWNER", "body": "Watch out for places in the documentation that might link to `master` - e.g. here:\r\n\r\nhttps://github.com/simonw/datasette/blob/2d7fa8b9058dfbf9c7c371cdeec115d32a177dc9/docs/custom_templates.rst#L247", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 639072811, "label": "Rename master branch to main"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/849#issuecomment-667424020", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/849", "id": 667424020, "node_id": "MDEyOklzc3VlQ29tbWVudDY2NzQyNDAyMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-31T23:21:30Z", "updated_at": "2020-07-31T23:21:30Z", "author_association": "OWNER", "body": "https://github.com/simonw/datasette/tree/main branch now exists and will automatically mirror master (and vice-versa).", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 639072811, "label": "Rename master branch to main"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/849#issuecomment-667424128", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/849", "id": 667424128, "node_id": "MDEyOklzc3VlQ29tbWVudDY2NzQyNDEyOA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-31T23:21:56Z", "updated_at": "2020-07-31T23:23:24Z", "author_association": "OWNER", "body": "I'm going to change the default branch on the GitHub repository. If something breaks I can always change it back again.\r\n\r\nDone that! Default is now `main`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 639072811, "label": "Rename master branch to main"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/913#issuecomment-667429616", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/913", "id": 667429616, "node_id": "MDEyOklzc3VlQ29tbWVudDY2NzQyOTYxNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-31T23:48:25Z", "updated_at": "2020-07-31T23:49:59Z", "author_association": "OWNER", "body": "I could let plugins add additional options to `datasette serve` - but what if two plugins both try to register an option with the same name?\r\n\r\nA better solution could be to use the existing `--config` option - and allow plugins to register their own, namespaced config options. So you could do things like:\r\n\r\n    datasette my.db --config datasette-insert:unsafe:1\r\n\r\nMaybe even drop the `datasette-` prefix?\r\n\r\n    datasette my.db --config insert:unsafe:1\r\n\r\nI think I prefer keeping the prefix to be honest - it makes it more obvious that this is a setting which comes from a specific named plugin.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 670209331, "label": "Mechanism for passing additional options to `datasette my.db` that affect plugins"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/913#issuecomment-667429690", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/913", "id": 667429690, "node_id": "MDEyOklzc3VlQ29tbWVudDY2NzQyOTY5MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-31T23:48:48Z", "updated_at": "2020-07-31T23:48:48Z", "author_association": "OWNER", "body": "Here's the code in Datasette that parses `--config` options at the moment:\r\n\r\nhttps://github.com/simonw/datasette/blob/7ca8c0521ac1ea48a3cd8d0fe9275d1316e54b43/datasette/cli.py#L25-L40", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 670209331, "label": "Mechanism for passing additional options to `datasette my.db` that affect plugins"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/913#issuecomment-667430352", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/913", "id": 667430352, "node_id": "MDEyOklzc3VlQ29tbWVudDY2NzQzMDM1Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-31T23:52:10Z", "updated_at": "2020-07-31T23:52:10Z", "author_association": "OWNER", "body": "The bigger question here is when this mechanism should be used in place of `metadata.json` or `metadata.yml`. Especially since I'm already considering renaming or reworking that mechanism since plugin configuration has nothing to do with database metadata: #493", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 670209331, "label": "Mechanism for passing additional options to `datasette my.db` that affect plugins"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/899#issuecomment-667430790", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/899", "id": 667430790, "node_id": "MDEyOklzc3VlQ29tbWVudDY2NzQzMDc5MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-31T23:54:40Z", "updated_at": "2020-07-31T23:54:40Z", "author_association": "OWNER", "body": "There's no mechanism that can do this at the moment.\r\n\r\nYou could absolutely support this with a plugin, probably using the `asgi_wrapper` plugin hook. There's an existing package at https://pypi.org/project/asgi-ratelimit/ which may be usable for this - it may even be possible to configure that using https://github.com/simonw/datasette-configure-asgi rather than using it to write a custom plugin.\r\n\r\nUsing a separate revers proxy would also be a good way to solve this. It depends which option would work best in your environment.\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 660827546, "label": "How to setup a request limit per user"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/900#issuecomment-667431123", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/900", "id": 667431123, "node_id": "MDEyOklzc3VlQ29tbWVudDY2NzQzMTEyMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-07-31T23:56:33Z", "updated_at": "2020-07-31T23:56:33Z", "author_association": "OWNER", "body": "I think this is the same issue as #865. I'll look at these together!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 661605489, "label": "Some links don't honor base_url"}, "performed_via_github_app": null}