{"html_url": "https://github.com/simonw/datasette/issues/1661#issuecomment-1068553454", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1661", "id": 1068553454, "node_id": "IC_kwDOBm6k_c4_sNTu", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-15T23:14:37Z", "updated_at": "2022-03-15T23:14:37Z", "author_association": "OWNER", "body": "This is going to simplify the code in the various view classes substantially:\r\n- #1660", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1170355774, "label": "Remove Hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1661#issuecomment-1068554827", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1661", "id": 1068554827, "node_id": "IC_kwDOBm6k_c4_sNpL", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-15T23:16:58Z", "updated_at": "2022-03-15T23:18:58Z", "author_association": "OWNER", "body": "If you attempt to use the [old setting](https://docs.datasette.io/en/stable/settings.html#hash-urls):\r\n\r\n datasette mydatabase.db --setting hash_urls 1\r\n\r\nIt should error with a message saying that the feature has been moved to a plugin.\r\n\r\nI'll do this with a `deprecated_settings` mechanism so the error can be detected even though `datasette --help-settings` will no longer return the setting.\r\n\r\nhttps://github.com/simonw/datasette/blob/77a904fea14f743560af9cc668146339bdbbd0a9/datasette/cli.py#L479-L489", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1170355774, "label": "Remove Hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1661#issuecomment-1068628839", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1661", "id": 1068628839, "node_id": "IC_kwDOBm6k_c4_sftn", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-16T01:21:36Z", "updated_at": "2022-03-16T01:21:48Z", "author_association": "OWNER", "body": "From https://docs.datasette.io/en/0.60.2/performance.html#hashed-url-mode\r\n\r\n> You can enable these hashed URLs in two ways: using the [hash_urls](https://docs.datasette.io/en/0.60.2/settings.html#setting-hash-urls) configuration setting (which affects all requests to Datasette) or via the `?_hash=1` query string parameter (which only applies to the current request).\r\n\r\nI'm going to drop` ?_hash=1` entirely. I'd actually forgotten that feature existed!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1170355774, "label": "Remove Hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1661#issuecomment-1068630353", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1661", "id": 1068630353, "node_id": "IC_kwDOBm6k_c4_sgFR", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-16T01:24:56Z", "updated_at": "2022-03-16T01:25:49Z", "author_association": "OWNER", "body": "Here's the only bit of code that references that `_hash` mechanism:\r\n\r\nhttps://github.com/simonw/datasette/blob/77a904fea14f743560af9cc668146339bdbbd0a9/datasette/views/base.py#L259-L265\r\n\r\nAnd here's the test:\r\n\r\nhttps://github.com/simonw/datasette/blob/77a904fea14f743560af9cc668146339bdbbd0a9/tests/test_api.py#L828-L854\r\n\r\nRelated issue:\r\n- #471", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1170355774, "label": "Remove Hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1661#issuecomment-1068728484", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1661", "id": 1068728484, "node_id": "IC_kwDOBm6k_c4_s4Ck", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-16T04:47:39Z", "updated_at": "2022-03-16T04:47:39Z", "author_association": "OWNER", "body": "https://datasette.io/plugins/datasette-hashed-urls is released now.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1170355774, "label": "Remove Hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1661#issuecomment-1071706993", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1661", "id": 1071706993, "node_id": "IC_kwDOBm6k_c4_4PNx", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-17T22:42:21Z", "updated_at": "2022-03-17T22:42:21Z", "author_association": "OWNER", "body": "As part of this I'm going to get rid of this mechanism: https://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/views/base.py#L170-L173\r\n\r\nUnwrapping `request.scope[\"url_route\"][\"kwargs\"]` into keyword argument to view functions just made the code harder to follow.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1170355774, "label": "Remove Hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1661#issuecomment-1071793307", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1661", "id": 1071793307, "node_id": "IC_kwDOBm6k_c4_4kSb", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-17T23:17:32Z", "updated_at": "2022-03-17T23:17:32Z", "author_association": "OWNER", "body": "Surprisingly I managed to break https://latest.datasette.io/fixtures/custom_foreign_key_label while working on this change:\r\n\r\n\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1170355774, "label": "Remove Hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1661#issuecomment-1071797707", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1661", "id": 1071797707, "node_id": "IC_kwDOBm6k_c4_4lXL", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-17T23:19:24Z", "updated_at": "2022-03-17T23:19:24Z", "author_association": "OWNER", "body": "Moving this to PR so I can comment on individual lines:\r\n- #1664", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1170355774, "label": "Remove Hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1661#issuecomment-1072901159", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1661", "id": 1072901159, "node_id": "IC_kwDOBm6k_c4_8ywn", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-19T00:20:27Z", "updated_at": "2022-03-19T00:20:27Z", "author_association": "OWNER", "body": "I can remove the `default_cache_ttl_hashed` setting too.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1170355774, "label": "Remove Hashed URL mode"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1661#issuecomment-1072904703", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1661", "id": 1072904703, "node_id": "IC_kwDOBm6k_c4_8zn_", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-19T00:37:36Z", "updated_at": "2022-03-19T00:37:36Z", "author_association": "OWNER", "body": "Updated docs: https://docs.datasette.io/en/latest/performance.html#datasette-hashed-urls", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1170355774, "label": "Remove Hashed URL mode"}, "performed_via_github_app": null}