{"html_url": "https://github.com/simonw/datasette/issues/1667#issuecomment-1073040072", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1667", "id": 1073040072, "node_id": "IC_kwDOBm6k_c4_9UrI", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-19T16:34:02Z", "updated_at": "2022-03-19T16:34:02Z", "author_association": "OWNER", "body": "I called it `as_format` to avoid clashing with the Python built-in `format()` function when these things were turned into keyword arguments, but now that they're not I can use `format` instead.\r\n\r\nI think I'm going to go with `database`, `table`, `format` and `pks`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1174302994, "label": "Make route matched pattern groups more consistent"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1667#issuecomment-1073042554", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1667", "id": 1073042554, "node_id": "IC_kwDOBm6k_c4_9VR6", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-19T16:50:01Z", "updated_at": "2022-03-19T16:52:35Z", "author_association": "OWNER", "body": "OK, I've made this more consistent - I still need to address the fact that `format` can be `.json` or `json` or not used at all before I close this issue.\r\n\r\nhttps://github.com/simonw/datasette/blob/61419388c134001118aaf7dfb913562d467d7913/tests/test_routes.py#L15-L35", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1174302994, "label": "Make route matched pattern groups more consistent"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1667#issuecomment-1073076624", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1667", "id": 1073076624, "node_id": "IC_kwDOBm6k_c4_9dmQ", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-19T20:31:44Z", "updated_at": "2022-03-19T20:31:44Z", "author_association": "OWNER", "body": "I can now read `format` from `request.url_vars` and delete this code entirely: https://github.com/simonw/datasette/blob/b9c2b1cfc8692b9700416db98721fa3ec982f6be/datasette/views/base.py#L375-L381", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1174302994, "label": "Make route matched pattern groups more consistent"}, "performed_via_github_app": null}