{"html_url": "https://github.com/simonw/datasette/issues/1035#issuecomment-712963959", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1035", "id": 712963959, "node_id": "MDEyOklzc3VlQ29tbWVudDcxMjk2Mzk1OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-20T16:11:25Z", "updated_at": "2020-10-20T16:11:25Z", "author_association": "OWNER", "body": "Relevant code:\r\n\r\nhttps://github.com/simonw/datasette/blob/091441a4449beae559a8c0d007376dc85d3aa624/datasette/utils/__init__.py#L681-L696\r\n\r\nOnly used here:\r\n\r\nhttps://github.com/simonw/datasette/blob/091441a4449beae559a8c0d007376dc85d3aa624/datasette/views/base.py#L498-L502", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 725743755, "label": "datasette.urls.table(..., format=\"json\") argument"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1035#issuecomment-712965574", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1035", "id": 712965574, "node_id": "MDEyOklzc3VlQ29tbWVudDcxMjk2NTU3NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-20T16:13:57Z", "updated_at": "2020-10-20T16:13:57Z", "author_association": "OWNER", "body": "That `renderers[key] = path_with_format(` is in a base class which can be used for both arbitrary queries, canned queries and the table view. I think that's OK, but it means that the `format=\"json\"` argument on `datasette.urls.table()` won't be used by Datasette internally, it will just be available for plugins.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 725743755, "label": "datasette.urls.table(..., format=\"json\") argument"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1035#issuecomment-712976314", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1035", "id": 712976314, "node_id": "MDEyOklzc3VlQ29tbWVudDcxMjk3NjMxNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-20T16:21:42Z", "updated_at": "2020-10-20T16:21:42Z", "author_association": "OWNER", "body": "Makes me question if `datasette.urls` should grow functionality equivalent to the other path and querystring manipulation methods in `datasette.utils`:\r\n\r\nhttps://github.com/simonw/datasette/blob/66120a7a1cb592e8a21164cf537f62a4d7ab1dfc/datasette/utils/__init__.py#L216-L279", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 725743755, "label": "datasette.urls.table(..., format=\"json\") argument"}, "performed_via_github_app": null}