{"html_url": "https://github.com/simonw/datasette/issues/1366#issuecomment-856147450", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1366", "id": 856147450, "node_id": "MDEyOklzc3VlQ29tbWVudDg1NjE0NzQ1MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-06-07T18:02:13Z", "updated_at": "2021-06-07T18:02:13Z", "author_association": "OWNER", "body": "The hack in question is this fixture, which I've been using in an ad-hoc manner to work around errors while running the tests: https://github.com/simonw/datasette/blob/030deb4b25cda842ff7129ab7c18550c44dd8379/tests/conftest.py#L62-L75\r\n\r\nI don't understand the underlying issue well enough to know how to get rid of it.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 913809802, "label": "Get rid of this `restore_working_directory` hack entirely"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1366#issuecomment-856147969", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1366", "id": 856147969, "node_id": "MDEyOklzc3VlQ29tbWVudDg1NjE0Nzk2OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-06-07T18:03:03Z", "updated_at": "2021-06-07T18:03:03Z", "author_association": "OWNER", "body": "Here's an example of a test that uses it. It's necessary because sometimes fixtures that create temporary directories break in unexpected ways:\r\n\r\nhttps://github.com/simonw/datasette/blob/0a7621f96f8ad14da17e7172e8a7bce24ef78966/tests/test_plugins.py#L658-L666", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 913809802, "label": "Get rid of this `restore_working_directory` hack entirely"}, "performed_via_github_app": null}