home / github / issue_comments

Menu
  • GraphQL API

issue_comments: 1029297971

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/sqlite-utils/pull/385#issuecomment-1029297971 https://api.github.com/repos/simonw/sqlite-utils/issues/385 1029297971 IC_kwDOCGYnMM49Wdcz 9599 2022-02-03T18:52:50Z 2022-02-03T18:52:50Z OWNER I'm not sure I like `name="geometry"` as the default argument to `add_geometry_column` - mainly because of this example here: ```python add_geometry_column(db["locations"], "POINT") create_spatial_index(db["locations"], "geometry") ``` I had to go and look at the code to figure out if `"POINT"` was the name of the column - and I don't like how inconsistent it looks next to the following `create_spatial_index()` call where you DO need to pass the column name. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} 1102899312  
Powered by Datasette · Queries took 1.006ms