home / github / issue_comments

Menu
  • GraphQL API

issue_comments: 1073037939

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/878#issuecomment-1073037939 https://api.github.com/repos/simonw/datasette/issues/878 1073037939 IC_kwDOBm6k_c4_9UJz 9599 2022-03-19T16:19:30Z 2022-03-19T16:19:30Z OWNER On revisiting https://gist.github.com/simonw/281eac9c73b062c3469607ad86470eb2 a few months later I'm having second thoughts about using `@inject` on the `main()` method. But I still like the pattern as a way to resolve more complex cases like "to generate GeoJSON of the expanded view with labels, the label expansion code needs to run once at some before the GeoJSON formatting code does". So I'm going to stick with it a tiny bit longer, but maybe try to make it a lot more explicit when it's going to happen rather than having the main view methods themselves also use async DI. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} 648435885  
Powered by Datasette · Queries took 0.743ms