issue_comments: 1179757605
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/simonw/datasette/issues/1048#issuecomment-1179757605 | https://api.github.com/repos/simonw/datasette/issues/1048 | 1179757605 | IC_kwDOBm6k_c5GUawl | 9599 | 2022-07-10T16:19:42Z | 2022-07-10T16:21:03Z | OWNER | If I do require `pks` to be passed here, maybe I could make those available to the `render_cell()` plugin hook to at least make this a bit more pleasant for plugin authors to use? Current hook: https://docs.datasette.io/en/latest/plugin_hooks.html#render-cell-row-value-column-table-database-datasette https://github.com/simonw/datasette/blob/035dc5e7b95142d4a700819a8cc4ff64aefe4efe/datasette/hookspecs.py#L62-L64 The hook is called in two places in the codebase - when rendering a table (`pks` variable is already in scope here): https://github.com/simonw/datasette/blob/6373bb341457e5becfd5b67792ac2c8b9ed7c384/datasette/views/table.py#L897-L904 And when rendering an arbitrary query: https://github.com/simonw/datasette/blob/6373bb341457e5becfd5b67792ac2c8b9ed7c384/datasette/views/database.py#L377-L384 Note that in that second one `table` is `None` (which is also called out in the documentation) - `pks` would be `None` here too. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 728905098 |