issue_comments: 1186620168
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/simonw/datasette/issues/1770#issuecomment-1186620168 | https://api.github.com/repos/simonw/datasette/issues/1770 | 1186620168 | IC_kwDOBm6k_c5GumMI | 9599 | 2022-07-17T22:37:01Z | 2022-07-17T22:37:01Z | OWNER | I need to refactor this code so that `Forbidden` exceptions are handled separately. Reason is that those already have a plugin hook of their own: https://github.com/simonw/datasette/blob/8188f55efc0fcca1be692b0d0c875f2d1ee99f17/datasette/app.py#L1384-L1395 My first attempt at this refactored that entire `handle_exception` method to call the new plugin hook, moving its current implementation into a `datasette/handle_exception.py` default plugin implementation - but it felt weird having that plugin implementation then itself call the `pm.hook.forbidden()` hook. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 1306492437 |