home / github / issue_comments

Menu
  • GraphQL API

issue_comments: 1291149509

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/sqlite-utils/issues/495#issuecomment-1291149509 https://api.github.com/repos/simonw/sqlite-utils/issues/495 1291149509 IC_kwDOCGYnMM5M9WDF 9599 2022-10-25T21:12:11Z 2022-10-25T21:12:11Z OWNER This makes sense to me. There are other places in the codebase where JSON is automatically stringified: https://github.com/simonw/sqlite-utils/blob/c7e4308e6f49d929704163531632e558f9646e4a/sqlite_utils/db.py#L2759-L2766 I don't see why the return value from a convert function shouldn't do the same thing. Since this will result in previous errors working, I don't think it warrants a major version bump either. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} 1392690202  
Powered by Datasette · Queries took 0.595ms