issue_comments: 1343751860
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/simonw/datasette/issues/1939#issuecomment-1343751860 | https://api.github.com/repos/simonw/datasette/issues/1939 | 1343751860 | IC_kwDOBm6k_c5QGAa0 | 9599 | 2022-12-09T02:18:11Z | 2022-12-09T02:19:23Z | OWNER | Should I rename "permission" to "action" elsewhere too? Maybe have a `register_actions(...)` plugin hook instead of adding `register_permissions(...)`? What else could the word "action" mean? Currently it's used in the codebase to refer to GitHub Actions, and for code like this: ```python if await self.permission_allowed( actor=actor, action="view-instance", default=True ): ``` Which is already revealing the confusion between "permission" and "action". | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 1485757511 |