issue_comments: 489420385
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/simonw/datasette/issues/454#issuecomment-489420385 | https://api.github.com/repos/simonw/datasette/issues/454 | 489420385 | MDEyOklzc3VlQ29tbWVudDQ4OTQyMDM4NQ== | 9599 | 2019-05-05T12:07:56Z | 2019-05-05T12:10:13Z | OWNER | Since I want the option to store more than one host, I don't think this should be a command-line option or a `--config` setting. Instead, I'm inclined to add this to `metadata.json`. Maybe this should be a plugin? That way the `metadata.json` setting could look like this: ``` { "title": "Title of this instance", "plugins": { "datasette-cors": { "allowed_origins": ["https://example.com"] } } } ``` This could be implemented easily on top of ASGI #272. (It should probably raise an exception on startup if any of the `allowed_origins` ends with a slash e.g. `"https://example.com/"` since that's not actually a valid origin, and it's an easy mistake to make.) | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 440437037 |