issue_comments: 504696638
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/simonw/datasette/issues/516#issuecomment-504696638 | https://api.github.com/repos/simonw/datasette/issues/516 | 504696638 | MDEyOklzc3VlQ29tbWVudDUwNDY5NjYzOA== | 9599 | 2019-06-22T20:37:25Z | 2019-06-22T20:38:42Z | OWNER | This test added do `test_black.py` seems to do the trick: ```python @pytest.mark.parametrize("path", code_root.glob("**/*.py")) def test_isort(path): # Have to capture stdout because isort uses print() directly stdout = sys.stdout sys.stdout = io.StringIO() result = isort.SortImports(path, check=True) assert ( not result.incorrectly_sorted ), "{} has incorrectly sorted imports, fix with 'isort -rc . && black .'" sys.stdout = stdout ``` I'll rename `test_black.py` to `test_lint.py` to reflect that it now covers more forms of linting. Also needed: add `move_to_front(items, "test_isort")` to `conftest.py`. And add `isort` to `extras_require` in `setup.py`. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 459509126 |