issue_comments: 510542280
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/simonw/datasette/pull/554#issuecomment-510542280 | https://api.github.com/repos/simonw/datasette/issues/554 | 510542280 | MDEyOklzc3VlQ29tbWVudDUxMDU0MjI4MA== | 9599 | 2019-07-11T15:47:31Z | 2019-07-11T15:47:31Z | OWNER | Thanks for this! The tests are failing for Python 3.5 right now which is strange. https://travis-ci.org/simonw/datasette/jobs/556272017 One failure looks like this: ``` app_client = <tests.fixtures.TestClient object at 0x7fb7803285f8> def test_static(app_client): response = app_client.get("/-/static/app2.css") > assert response.status == 404 E assert 500 == 404 E + where 500 = <tests.fixtures.TestResponse object at 0x7fb780328a58>.status /home/travis/build/simonw/datasette/tests/test_html.py:56: AssertionError ----------------------------- Captured stderr call ----------------------------- Traceback (most recent call last): File "/home/travis/build/simonw/datasette/datasette/utils/asgi.py", line 100, in __call__ return await view(new_scope, receive, send) File "/home/travis/build/simonw/datasette/datasette/utils/asgi.py", line 303, in inner_static full_path = (Path(root_path) / path).resolve().absolute() File "/opt/python/3.5.6/lib/python3.5/pathlib.py", line 1109, in resolve s = self._flavour.resolve(self) File "/opt/python/3.5.6/lib/python3.5/pathlib.py", line 330, in resolve return _resolve(base, str(path)) or sep File "/opt/python/3.5.6/lib/python3.5/pathlib.py", line 315, in _resolve target = accessor.readlink(newpath) File "/opt/python/3.5.6/lib/python3.5/pathlib.py", line 422, in readlink return os.readlink(path) FileNotFoundError: [Errno 2] No such file or directory: '/home/travis/build/simonw/datasette/datasette/static/app2.css' ``` Maybe an exception was renamed between 3.5 and 3.6? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 465728430 |