issue_comments: 541495034
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/simonw/datasette/pull/590#issuecomment-541495034 | https://api.github.com/repos/simonw/datasette/issues/590 | 541495034 | MDEyOklzc3VlQ29tbWVudDU0MTQ5NTAzNA== | 9599 | 2019-10-14T03:51:32Z | 2019-10-14T03:51:32Z | OWNER | We need some unit tests for this. I'd be fine with us renaming `extra_database.db` to `extra database.py` in these existing fixtures: https://github.com/simonw/datasette/blob/af2e6a5cf186a7200d76cb67ac30fa59cc24d84e/tests/fixtures.py#L174-L185 Then we could add an extra `test_database_name_with_spaces(...)` test in `test_api.py` which uses parametrize to exercise a bunch of URLs and check they all return a 200 - something a bit like this but covering a range of URL paths (one for database, table, row and table with filters): https://github.com/simonw/datasette/blob/90d4f497f9b3f6a5882937c91fddb496ac3e7368/tests/test_api.py#L746-L765 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 505818256 |