issue_comments: 554869243
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/simonw/datasette/issues/620#issuecomment-554869243 | https://api.github.com/repos/simonw/datasette/issues/620 | 554869243 | MDEyOklzc3VlQ29tbWVudDU1NDg2OTI0Mw== | 9599 | 2019-11-18T06:16:17Z | 2019-11-18T06:16:51Z | OWNER | I think I should move the `ds.expand_foreign_keys()` method somewhere else: https://github.com/simonw/datasette/blob/c2779e5af0d056ef1637f9f0e191dca421259a5e/datasette/app.py#L355-L390 Moving it to `Database` makes sense to me. The question we then ask it is: "Given this column containing these values, give me back a dictionary mapping each column and value to a label - `(column, value) -> label`" Passing in the foreign keys we have calculated as an argument makes sense. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 520667773 |