home / github / issue_comments

Menu
  • GraphQL API

issue_comments: 582100643

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/pull/653#issuecomment-582100643 https://api.github.com/repos/simonw/datasette/issues/653 582100643 MDEyOklzc3VlQ29tbWVudDU4MjEwMDY0Mw== 9599 2020-02-04T20:29:56Z 2020-02-04T20:29:56Z OWNER I think there's one nasty edge-case here that we need to worry about: SQLite allows newlines inside of single quoted strings and I've actually started using that in quite a few places - it's great for [embedding markdown in a string](https://github.com/simonw/datasette-render-markdown) for example. The way you're stripping comments right now splits on newlines and removes any lines that start with `--`. I believe that will mangle the following example: ```sql select '# Hello there * This is a list * of items -- [And a link](https://github.com/simonw/datasette-render-markdown).' as demo_markdown ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} 541331755  
Powered by Datasette · Queries took 5.35ms