issue_comments: 609887635
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/717#issuecomment-609887635 | https://api.github.com/repos/simonw/datasette/issues/717 | 609887635 | MDEyOklzc3VlQ29tbWVudDYwOTg4NzYzNQ== | 9599 | 2020-04-06T16:07:51Z | 2020-04-06T16:08:47Z | OWNER | Built myself a quick ASGI scope debugging tool: https://now-2-asgi-scope.now.sh/ Same `now.json` as above, but `index.py` is this: ```python from pprint import pformat async def app(scope, receive, send): await send({ 'type': 'http.response.start', 'status': 200, 'headers': [ [b'content-type', b'text/plain'], ], }) await send({ 'type': 'http.response.body', 'body': pformat(scope).encode('utf8'), }) ``` https://now-2-asgi-scope.now.sh/fixtures/table%2Fwith%2Fslashes.csv shows what's going on - those `%2F` have been decoded to `/` before they get to the ASGI app - probably by the Now routing layer: ``` ... 'http_version': '1.1', 'method': 'GET', 'path': '/fixtures/table/with/slashes.csv', 'query_string': b'', 'raw_path': b'/fixtures/table/with/slashes.csv', ... ``` That `raw_path` there needs to be `b'/fixtures/table%2Fwith%2Fslashes.csv'` in order for Datasette to fully work here. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 594189527 |