issue_comments: 719110582
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/simonw/datasette/issues/1064#issuecomment-719110582 | https://api.github.com/repos/simonw/datasette/issues/1064 | 719110582 | MDEyOklzc3VlQ29tbWVudDcxOTExMDU4Mg== | 9599 | 2020-10-30T01:11:13Z | 2020-10-30T01:11:13Z | OWNER | Should plugins be able to add forms like the logout form here, or should they be restricted to adding navigation links? I can't think of a reason a plugin would need to add a form. The logout form is a special case to protect against logout-csrf attacks. So I think plugins get to return a list of dictionaries, each with a `label` and an `href`: ```python return [{ "label": "Upload CSVs", "href": datasette.urls.path("/-/upload-csvs") }] ``` But... is there an argument for returning headings, to divide up the menu? I think so. I also like the idea that a default plugin checks for the `root` user and outputs links to the different debugging tools - maybe those should be wrapped in a section heading. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 732798913 |