home / github / issue_comments

Menu
  • GraphQL API

issue_comments: 850059328

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/pull/1346#issuecomment-850059328 https://api.github.com/repos/simonw/datasette/issues/1346 850059328 MDEyOklzc3VlQ29tbWVudDg1MDA1OTMyOA== 9599 2021-05-28T02:08:10Z 2021-05-28T02:09:25Z OWNER This is the current test failure, but it actually another problem that we don't have tests in place for errors with different formats and shapes: ``` def test_magic_parameters_cannot_be_used_in_arbitrary_queries(magic_parameters_client): response = magic_parameters_client.get( "/data.json?sql=select+:_header_host&_shape=array" ) assert 400 == response.status > assert "You did not supply a value for binding 1." == response.json["error"] E TypeError: list indices must be integers or slices, not str ``` The test fails because `response.json` here is the empty list `[]`. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} 904537568  
Powered by Datasette · Queries took 0.908ms