issue_comments: 851114806
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1345#issuecomment-851114806 | https://api.github.com/repos/simonw/datasette/issues/1345 | 851114806 | MDEyOklzc3VlQ29tbWVudDg1MTExNDgwNg== | 9599 | 2021-05-31T01:55:56Z | 2021-05-31T01:55:56Z | OWNER | Two options here: - Don't provide users with options that will lead to this situation - so no "Hide this column" option on pages that are already faceted by that column - Ignore facet selections for columns which are no longer visible I think I like the first option more. I could partially implement that in the `table.js` JavaScript by looking at the `?_facet=` parameters... but that won't cover the case where the facet is happening because of default facets configured in `metadata.yml`. Instead the JavaScript should look for evidence in the DOM that specific facets are enabled. This could also help me cover other types of faceting, such as `?_facet_array=` or even custom facets provided by plugins. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | 904071938 |