home / github / issue_comments

Menu
  • GraphQL API

issue_comments: 974398399

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions issue performed_via_github_app
https://github.com/simonw/datasette/issues/1519#issuecomment-974398399 https://api.github.com/repos/simonw/datasette/issues/1519 974398399 IC_kwDOBm6k_c46FCO_ 9599 2021-11-19T20:08:20Z 2021-11-19T20:22:02Z OWNER The relevant test is this one: https://github.com/simonw/datasette/blob/30255055150d7bc0affc8156adc18295495020ff/tests/test_html.py#L1608-L1649 I modified that test to add `"/fixtures/facetable?sql=select+1"` as one of the tested paths, and dropped in an `assert False` to pause it in the debugger: ``` @pytest.mark.parametrize( "path", [ "/", "/fixtures", "/fixtures/compound_three_primary_keys", "/fixtures/compound_three_primary_keys/a,a,a", "/fixtures/paginated_view", "/fixtures/facetable", "/fixtures?sql=select+1", ], ) def test_base_url_config(app_client_base_url_prefix, path): client = app_client_base_url_prefix response = client.get("/prefix/" + path.lstrip("/")) soup = Soup(response.body, "html.parser") if path == "/fixtures?sql=select+1": > assert False E assert False ``` BUT... in the debugger: ``` (Pdb) print(soup) ... <p class="export-links">This data as <a href="/prefix/fixtures.json?sql=select+1">json</a>, <a href="/prefix/fixtures.testall?sql=select+1">testall</a>, <a href="/prefix/fixtures.testnone?sql=select+1">testnone</a>, <a href="/prefix/fixtures.testresponse?sql=select+1">testresponse</a>, <a href="/prefix/fixtures.csv?sql=select+1&amp;_size=max">CSV</a></p> ``` Those all have the correct prefix! But that's not what I'm seeing in my `Dockerfile` reproduction of the issue. Something very weird is going on here. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} 1058790545  
Powered by Datasette · Queries took 0.94ms