issue_comments
7 rows where author_association = "OWNER" and "created_at" is on date 2022-01-12
This data as json, CSV (advanced)
Suggested facets: issue_url, issue, updated_at (date)
id ▼ | html_url | issue_url | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
1010533133 | https://github.com/simonw/datasette/issues/1590#issuecomment-1010533133 | https://api.github.com/repos/simonw/datasette/issues/1590 | IC_kwDOBm6k_c48O4MN | simonw 9599 | 2022-01-12T01:19:19Z | 2022-01-12T01:19:19Z | OWNER | Thanks for the steps to reproduce - I have your bug running on my laptop now. I've been mostly testing this stuff using the hosted copy of Datasette here, which doesn't exhibit the bug: https://datasette-apache-proxy-demo.fly.dev/prefix/fixtures?sql=select+sqlite_version%28%29 Something interesting definitely going on here! | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Table+query JSON and CSV links broken when using `base_url` setting 1099723916 | |
1010537058 | https://github.com/simonw/datasette/issues/1590#issuecomment-1010537058 | https://api.github.com/repos/simonw/datasette/issues/1590 | IC_kwDOBm6k_c48O5Ji | simonw 9599 | 2022-01-12T01:26:34Z | 2022-01-12T01:26:34Z | OWNER | I'm using the https://datasette.io/plugins/datasette-debug-asgi plugin to investigate. On my laptop using Daphne I get this: http://127.0.0.1:8032/datasettes/-/asgi-scope ``` {'actor': None, 'asgi': {'version': '3.0'}, 'client': ['127.0.0.1', 53767], 'csrftoken': <function asgi_csrf_decorator.<locals>._asgi_csrf_decorator.<locals>.app_wrapped_with_csrf.<locals>.get_csrftoken at 0x1122aeef0>, 'headers': [(b'host', b'127.0.0.1:8032'), (b'user-agent', b'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:95.0) Gecko' b'/20100101 Firefox/95.0'), (b'accept', b'text/html,application/xhtml+xml,application/xml;q=0.9,image/' b'avif,image/webp,*/*;q=0.8'), (b'accept-language', b'en-US,en;q=0.5'), (b'accept-encoding', b'gzip, deflate'), (b'dnt', b'1'), (b'connection', b'keep-alive'), (b'cookie', b'_ga=GA1.1.742283954.1628542653'), (b'upgrade-insecure-requests', b'1'), (b'sec-fetch-dest', b'document'), (b'sec-fetch-mode', b'navigate'), (b'sec-fetch-site', b'none'), (b'sec-fetch-user', b'?1')], 'http_version': '1.1', 'method': 'GET', 'path': '/datasettes/-/asgi-scope', 'path_remaining': '', 'query_string': b'', 'raw_path': b'/datasettes/-/asgi-scope', 'root_path': '', 'route_path': '/-/asgi-scope', 'scheme': 'http', 'server': ['127.0.0.1', 8032], 'type': 'http', 'url_route': {'kwargs': {}}} ``` On the demo running on Fly (which I just redeployed with that plugin) I get this: https://datasette-apache-proxy-demo.fly.dev/prefix/-/asgi-scope ``` {'actor': None, 'asgi': {'spec_version': '2.1', 'version': '3.0'}, 'client': ('86.109.12.167', 0), 'csrftoken': <function asgi_csrf_decorator.<locals>._asgi_csrf_decorator.<locals>.app_wrapped_with_csrf.<locals>.get_csrftoken at 0x7f4c0413bca0>, 'headers': [(b'host', b'datasette-apache-proxy-demo.fly.dev'), … | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Table+query JSON and CSV links broken when using `base_url` setting 1099723916 | |
1010538016 | https://github.com/simonw/datasette/issues/1590#issuecomment-1010538016 | https://api.github.com/repos/simonw/datasette/issues/1590 | IC_kwDOBm6k_c48O5Yg | simonw 9599 | 2022-01-12T01:28:19Z | 2022-01-12T01:28:19Z | OWNER | The Daphne one has this key: `'route_path': '/-/asgi-scope',` Maybe Datasette's routing code needs to look out for that, if it's available, and use it to reconstruct the requested path? The code in question is here: https://github.com/simonw/datasette/blob/8c401ee0f054de2f568c3a8302c9223555146407/datasette/app.py#L1143-L1149 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Table+query JSON and CSV links broken when using `base_url` setting 1099723916 | |
1010538188 | https://github.com/simonw/datasette/issues/1590#issuecomment-1010538188 | https://api.github.com/repos/simonw/datasette/issues/1590 | IC_kwDOBm6k_c48O5bM | simonw 9599 | 2022-01-12T01:28:41Z | 2022-01-12T01:30:43Z | OWNER | Oh wait! It looks like `route_path` is something I invented there. Yup, I added it in https://github.com/simonw/datasette/commit/a63412152518581c6a3d4e142b937e27dabdbfdb - commit message says: > - new `route_path` key in `request.scope` storing the path that was used for routing with the `base_url` prefix stripped So actually part of the mystery here is: why does the Fly hosted one NOT have that key? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Table+query JSON and CSV links broken when using `base_url` setting 1099723916 | |
1010540923 | https://github.com/simonw/datasette/issues/1590#issuecomment-1010540923 | https://api.github.com/repos/simonw/datasette/issues/1590 | IC_kwDOBm6k_c48O6F7 | simonw 9599 | 2022-01-12T01:33:49Z | 2022-01-12T01:33:49Z | OWNER | Looking closer at the code quoted above, it doesn't modify `path` or `raw_path` at all - ALL it does is add the `route_path` to the scope. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Table+query JSON and CSV links broken when using `base_url` setting 1099723916 | |
1010764036 | https://github.com/simonw/datasette/issues/1591#issuecomment-1010764036 | https://api.github.com/repos/simonw/datasette/issues/1591 | IC_kwDOBm6k_c48PwkE | simonw 9599 | 2022-01-12T08:22:16Z | 2022-01-12T08:22:32Z | OWNER | The challenge here is avoiding clashes. What if a plugin adds an option that I later want to use for a new Datasette core feature? Or what if two plugins define the same option? Maybe the solution is to make them use namespaces defined by the plugin name. How about this: datasette t.db --plugin-setting datasette-tiddlywiki db t.db It's a bit verbose having an option that itself then takes THREE strings: plugin name, setting name, setting value - but it would work. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Maybe let plugins define custom serve options? 1100015398 | |
1011185061 | https://github.com/simonw/datasette/issues/1592#issuecomment-1011185061 | https://api.github.com/repos/simonw/datasette/issues/1592 | IC_kwDOBm6k_c48RXWl | simonw 9599 | 2022-01-12T15:50:41Z | 2022-01-12T15:50:41Z | OWNER | Twitter: https://twitter.com/dracos/status/1481290103519592459 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Row pages should show links to foreign keys 1100499619 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
created_at (date) 1 ✖