issue_comments
8 rows where "updated_at" is on date 2021-11-30 sorted by html_url
This data as json, CSV (advanced)
Suggested facets: issue_url, issue
id | html_url ▼ | issue_url | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
982331602 | https://github.com/simonw/datasette/issues/1525#issuecomment-982331602 | https://api.github.com/repos/simonw/datasette/issues/1525 | IC_kwDOBm6k_c46jTDS | simonw 9599 | 2021-11-30T06:39:00Z | 2021-11-30T06:39:00Z | OWNER | These two pages now help demonstrate the fix: - https://latest.datasette.io/fixtures/facet_cities/1 - https://latest.datasette.io/fixtures/attraction_characteristic/2 I added a new test for these here: https://github.com/simonw/datasette/blob/35b12746ba2bf9f254791bddac03d25b19be9b77/tests/test_html.py#L823-L848 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | "Links from other tables" broken for columns starting with underscore 1059509927 | |
982235541 | https://github.com/simonw/datasette/issues/1527#issuecomment-982235541 | https://api.github.com/repos/simonw/datasette/issues/1527 | IC_kwDOBm6k_c46i7mV | simonw 9599 | 2021-11-30T02:57:34Z | 2021-11-30T02:58:44Z | OWNER | I started fiddling with a test for this which extracts the `<select>` options and ALL of the `<input>` fields, but I probably won't use it: ```python def test_exact_parameter_results_in_correct_hidden_fields(app_client): # https://github.com/simonw/datasette/issues/1527 response = app_client.get( "/fixtures/facetable?_facet=_neighborhood&_neighborhood__exact=Downtown" ) # In this case we should NOT have a hidden _neighborhood__exact=Downtown field form = Soup(response.body, "html.parser").find("form") selects = [ { "name": select["name"], "value": select.select("option[selected]")[0].text if select.select("option[selected]") else "", } for select in form.findAll("select") ] inputs = [input.attrs for input in form.findAll("input")] # Turn those both into a {name: (value, type)} array form_inputs = {} form_inputs.update( {select["name"]: (select["value"], "select") for select in selects} ) form_inputs.update( { input["name"]: (input.get("value"), input["type"]) for input in inputs if input.get("name") } ) assert form_inputs == { "_filter_column_1": ("_neighborhood", "select"), "_filter_op_1": ("=", "select"), "_filter_value_1": ("Downtown", "text"), "_filter_column": ("", "select"), "_filter_op": ("", "select"), "_filter_value": (None, "text"), "_sort": ("Sort by pk", "select"), "_sort_by_desc": (None, "checkbox"), "_facet": ("_neighborhood", "hidden"), "_neighborhood__exact": ("Downtown", "hidden"), } ``` The problem is that last hidden field, `_neighborhood__exact=Downtown` - which should not be there. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Columns starting with an underscore behave poorly in filters 1059555791 | |
982318745 | https://github.com/simonw/datasette/issues/1527#issuecomment-982318745 | https://api.github.com/repos/simonw/datasette/issues/1527 | IC_kwDOBm6k_c46jP6Z | simonw 9599 | 2021-11-30T06:11:21Z | 2021-11-30T06:11:21Z | OWNER | Manually tested this too, looks like that fixed it. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Columns starting with an underscore behave poorly in filters 1059555791 | |
982319210 | https://github.com/simonw/datasette/issues/1532#issuecomment-982319210 | https://api.github.com/repos/simonw/datasette/issues/1532 | IC_kwDOBm6k_c46jQBq | simonw 9599 | 2021-11-30T06:12:19Z | 2021-11-30T06:12:19Z | OWNER | That's really cool to hear - I've not seen many people actively building on top of the JSON API. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Use datasette-table Web Component to guide the design of the JSON API for 1.0 1065429936 | |
982745406 | https://github.com/simonw/datasette/issues/1532#issuecomment-982745406 | https://api.github.com/repos/simonw/datasette/issues/1532 | IC_kwDOBm6k_c46k4E- | 20after4 30934 | 2021-11-30T15:28:57Z | 2021-11-30T15:28:57Z | NONE | It's a really great API and the documentation is really great too. Honestly, in more than 20 years of professional experience, I haven't worked with any software API that was more of a joy to use. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Use datasette-table Web Component to guide the design of the JSON API for 1.0 1065429936 | |
977870699 | https://github.com/simonw/datasette/pull/1529#issuecomment-977870699 | https://api.github.com/repos/simonw/datasette/issues/1529 | IC_kwDOBm6k_c46SR9r | codecov[bot] 22429695 | 2021-11-24T13:18:52Z | 2021-11-30T02:30:46Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1529?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#1529](https://codecov.io/gh/simonw/datasette/pull/1529?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (2cb3dbb) into [main](https://codecov.io/gh/simonw/datasette/commit/48f11998b73350057b74fe6ab464d4ac3071637c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (48f1199) will **decrease** coverage by `0.06%`. > The diff coverage is `n/a`. > :exclamation: Current head 2cb3dbb differs from pull request most recent head 495b726. Consider uploading reports for the commit 495b726 to get more accurate results [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1529/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1529?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) ```diff @@ Coverage Diff @@ ## main #1529 +/- ## ========================================== - Coverage 91.90% 91.83% -0.07% ========================================== Files 34 34 Lines 4434 4434 ========================================== - Hits 4075 4072 -3 - Misses 359 362 +3 ``` | [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1529?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage Δ | | |---|---|---| | [datasette/views/index.py](https://codecov.io/gh/simonw/datasette/pull/1529/diff?src=pr&el=tree&utm_medium=… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Update janus requirement from <0.7,>=0.6.2 to >=0.6.2,<0.8 1062414013 | |
983120066 | https://github.com/simonw/sqlite-utils/issues/348#issuecomment-983120066 | https://api.github.com/repos/simonw/sqlite-utils/issues/348 | IC_kwDOCGYnMM46mTjC | simonw 9599 | 2021-11-30T23:25:52Z | 2021-11-30T23:26:11Z | OWNER | Maybe this: sqlite-utils create-database my.db With options that include `--enable-wal` (actually that's the only option I can think of). This is consistent with the existing `create-table` and `create-view` commands. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Command for creating an empty database 1067771698 | |
983122733 | https://github.com/simonw/sqlite-utils/issues/348#issuecomment-983122733 | https://api.github.com/repos/simonw/sqlite-utils/issues/348 | IC_kwDOCGYnMM46mUMt | simonw 9599 | 2021-11-30T23:31:17Z | 2021-11-30T23:31:17Z | OWNER | Potential other options could include: - `--page-size` https://www.sqlite.org/pragma.html#pragma_page_size | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Command for creating an empty database 1067771698 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
author_association 2 ✖