issue_comments
6 rows where "created_at" is on date 2019-07-09 sorted by issue_url
This data as json, CSV (advanced)
Suggested facets: issue_url, issue
updated_at (date) 2 ✖
- 2019-07-09 5
- 2021-06-22 1
id | html_url | issue_url ▼ | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
509480062 | https://github.com/simonw/datasette/issues/514#issuecomment-509480062 | https://api.github.com/repos/simonw/datasette/issues/514 | MDEyOklzc3VlQ29tbWVudDUwOTQ4MDA2Mg== | simonw 9599 | 2019-07-09T04:15:11Z | 2019-07-09T04:15:11Z | OWNER | Running as root isn't ideal because it means that if there are any security vulnerabilities in Datasette an attacker could use them to execute any command they like as root on your machine. I'm moderately confident there aren't any vulnerabilities like that, but I'm definite not 100% certain! My recommendation is to run Datasette on 127.0.0.1 port 8001 and then have nginx proxy port 80 to it. See https://github.com/simonw/datasette/issues/514#issuecomment-504663201 for suggested nginx configuration. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Documentation with recommendations on running Datasette in production without using Docker 459397625 | |
509618339 | https://github.com/simonw/datasette/pull/554#issuecomment-509618339 | https://api.github.com/repos/simonw/datasette/issues/554 | MDEyOklzc3VlQ29tbWVudDUwOTYxODMzOQ== | abdusco 3243482 | 2019-07-09T12:16:32Z | 2019-07-09T12:16:32Z | CONTRIBUTOR | I've also added another fix for using static mounts with absolute paths on Windows. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fix static mounts using relative paths and prevent traversal exploits 465728430 | |
509629331 | https://github.com/simonw/datasette/pull/554#issuecomment-509629331 | https://api.github.com/repos/simonw/datasette/issues/554 | MDEyOklzc3VlQ29tbWVudDUwOTYyOTMzMQ== | abdusco 3243482 | 2019-07-09T12:51:35Z | 2019-07-09T12:51:35Z | CONTRIBUTOR | I wanted to add a test for it too, but I've realized it's impossible to test a server process as we cannot get its exit code. ```python # tests/test_cli.py def test_static_mounts_on_windows(): if sys.platform != "win32": return runner = CliRunner() result = runner.invoke( cli, ["serve", "--static", r"s:C:\\"] ) assert result.exit_code == 0 ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fix static mounts using relative paths and prevent traversal exploits 465728430 | |
509681590 | https://github.com/simonw/sqlite-utils/issues/37#issuecomment-509681590 | https://api.github.com/repos/simonw/sqlite-utils/issues/37 | MDEyOklzc3VlQ29tbWVudDUwOTY4MTU5MA== | simonw 9599 | 2019-07-09T15:07:12Z | 2021-06-22T18:17:53Z | OWNER | Here's a magic incantation for generating types detected through running the tests with https://github.com/Instagram/MonkeyType ``` pip install pytest-monkeytype pytest --monkeytype-output=./monkeytype.sqlite3 monkeytype list-modules monkeytype apply sqlite_utils.utils monkeytype apply sqlite_utils.cli monkeytype apply sqlite_utils.db ``` Here's the result: https://github.com/simonw/sqlite-utils/commit/d18c694fc25b7dd3d76e250c77ddf56d10ddf935 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Experiment with type hints 465815372 | |
509685610 | https://github.com/simonw/sqlite-utils/issues/37#issuecomment-509685610 | https://api.github.com/repos/simonw/sqlite-utils/issues/37 | MDEyOklzc3VlQ29tbWVudDUwOTY4NTYxMA== | simonw 9599 | 2019-07-09T15:16:52Z | 2019-07-09T15:16:52Z | OWNER | Also interesting: ``` pip install pytest-mypy pytest --mypy ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Experiment with type hints 465815372 | |
509686432 | https://github.com/simonw/sqlite-utils/issues/37#issuecomment-509686432 | https://api.github.com/repos/simonw/sqlite-utils/issues/37 | MDEyOklzc3VlQ29tbWVudDUwOTY4NjQzMg== | simonw 9599 | 2019-07-09T15:18:49Z | 2019-07-09T15:18:49Z | OWNER | Interestingly if I run that against my `monkeytype` branch I get the following errors (subset): ``` _______________________________________________________________________________________ mypy db.py ________________________________________________________________________________________ sqlite_utils/db.py:15: error: No library stub file for module 'numpy' sqlite_utils/db.py:15: note: (Stub files are from https://github.com/python/typeshed) sqlite_utils/db.py:197: error: Incompatible types in assignment (expression has type "Union[Dict[str, int], Dict[str, Union[int, str]], Dict[str, str], Dict[<nothing>, <nothing>]]", variable has type "Union[Dict[str, int], Dict[str, Union[int, str]], Dict[str, str], None]") sqlite_utils/db.py:204: error: Item "None" of "Union[Dict[str, int], Dict[str, Union[int, str]], Dict[str, str], None]" has no attribute "__iter__" (not iterable) sqlite_utils/db.py:206: error: Argument 1 to "set" has incompatible type "Union[Dict[str, int], Dict[str, Union[int, str]], Dict[str, str], None]"; expected "Iterable[str]" sqlite_utils/db.py:211: error: Item "None" of "Optional[Tuple[str, str, str]]" has no attribute "index" sqlite_utils/db.py:211: error: Unsupported right operand type for in ("Optional[Tuple[str, str, str]]") sqlite_utils/db.py:232: error: Unsupported right operand type for in ("Union[Dict[str, int], Dict[str, Union[int, str]], Dict[str, str], None]") sqlite_utils/db.py:234: error: Value of type "Union[Dict[str, int], Dict[str, Union[int, str]], Dict[str, str], None]" is not indexable sqlite_utils/db.py:307: error: Need type annotation for 'table_sql' (hint: "table_sql: Dict[<type>, <type>] = ...") sqlite_utils/db.py:427: error: Item "int" of "Union[int, None, str]" has no attribute "startswith" sqlite_utils/db.py:427: error: Item "None" of "Union[int, None, str]" has no attribute "startswith" sqlite_utils/db.py:434: error: Incompatible types in assignment (expression has type "List[Any]", target has type "int") sqlite_utils/db.py:438: error: Incompatible types in… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Experiment with type hints 465815372 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
user 2 ✖