issue_comments
20 rows where "updated_at" is on date 2021-10-24 sorted by node_id
This data as json, CSV (advanced)
Suggested facets: issue_url, author_association, issue
id | html_url | issue_url | node_id ▼ | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
938141121 | https://github.com/simonw/datasette/pull/1481#issuecomment-938141121 | https://api.github.com/repos/simonw/datasette/issues/1481 | IC_kwDOBm6k_c436uXB | codecov[bot] 22429695 | 2021-10-07T20:42:37Z | 2021-10-24T22:19:28Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/1481?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report > Merging [#1481](https://codecov.io/gh/simonw/datasette/pull/1481?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (77542e7) into [main](https://codecov.io/gh/simonw/datasette/commit/63886178a649586b403966a27a45881709d2b868?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (6388617) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. > :exclamation: Current head 77542e7 differs from pull request most recent head 50005bd. Consider uploading reports for the commit 50005bd to get more accurate results [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1481/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1481?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) ```diff @@ Coverage Diff @@ ## main #1481 +/- ## ========================================== - Coverage 91.83% 91.82% -0.02% ========================================== Files 34 34 Lines 4421 4426 +5 ========================================== + Hits 4060 4064 +4 - Misses 361 362 +1 ``` | [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1481?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage Δ | | |---|---|---| | [datasette/app.py](https://codecov.io/gh/simonw/datasette/pull/1481/diff?src=pr&el=tree&utm_medium=referral… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Fix compatibility with Python 3.10 1020436713 | |
950402273 | https://github.com/simonw/datasette/issues/1482#issuecomment-950402273 | https://api.github.com/repos/simonw/datasette/issues/1482 | IC_kwDOBm6k_c44pfzh | simonw 9599 | 2021-10-24T22:00:29Z | 2021-10-24T22:00:29Z | OWNER | Janus 0.6.2 is out now and should have the fix. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Support Python 3.10 1021550542 | |
950403521 | https://github.com/simonw/datasette/pull/1495#issuecomment-950403521 | https://api.github.com/repos/simonw/datasette/issues/1495 | IC_kwDOBm6k_c44pgHB | simonw 9599 | 2021-10-24T22:09:18Z | 2021-10-24T22:09:18Z | OWNER | This is a great idea - I've wanted this myself before, but never spent any time thinking about how to achieve it. I think your design here is exactly right - an optional third item in the tuple consisting of a dictionary of options to pass to the view function. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Allow routes to have extra options 1033678984 | |
950403692 | https://github.com/simonw/datasette/pull/1495#issuecomment-950403692 | https://api.github.com/repos/simonw/datasette/issues/1495 | IC_kwDOBm6k_c44pgJs | simonw 9599 | 2021-10-24T22:10:43Z | 2021-10-24T22:10:43Z | OWNER | To land this change we'll need a unit test that demonstrates the new capability - I suggest putting that next to this test: https://github.com/simonw/datasette/blob/15a9d4abfff0c45dee2a9f851326e1d61b1c678c/tests/test_plugins.py#L648-L659 It will also need documentation, which should be added here: https://github.com/simonw/datasette/blob/15a9d4abfff0c45dee2a9f851326e1d61b1c678c/docs/plugin_hooks.rst#register-routes-datasette | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Allow routes to have extra options 1033678984 | |
950410554 | https://github.com/simonw/datasette/issues/1497#issuecomment-950410554 | https://api.github.com/repos/simonw/datasette/issues/1497 | IC_kwDOBm6k_c44ph06 | simonw 9599 | 2021-10-24T23:01:20Z | 2021-10-24T23:01:28Z | OWNER | I can replicate locally by running: ``` docker build -f Dockerfile \ -t datasetteproject/datasette:0.59.1 \ --build-arg VERSION=0.59.1 . ``` This gives me the same error. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Publish to Docker Hub failing with "libcrypt.so.1: cannot open shared object file" 1034535001 | |
950410718 | https://github.com/simonw/datasette/issues/1497#issuecomment-950410718 | https://api.github.com/repos/simonw/datasette/issues/1497 | IC_kwDOBm6k_c44ph3e | simonw 9599 | 2021-10-24T23:02:30Z | 2021-10-24T23:02:30Z | OWNER | I got the same error publishing 0.59: https://github.com/simonw/datasette/actions/runs/1343251945 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Publish to Docker Hub failing with "libcrypt.so.1: cannot open shared object file" 1034535001 | |
950415129 | https://github.com/simonw/datasette/issues/1497#issuecomment-950415129 | https://api.github.com/repos/simonw/datasette/issues/1497 | IC_kwDOBm6k_c44pi8Z | simonw 9599 | 2021-10-24T23:21:33Z | 2021-10-24T23:21:33Z | OWNER | That fixed it! Resulting image is 249MB which is a very slight size reduction (I think previous was 259MB (uncompressed). | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Publish to Docker Hub failing with "libcrypt.so.1: cannot open shared object file" 1034535001 | |
950411320 | https://github.com/simonw/datasette/issues/1497#issuecomment-950411320 | https://api.github.com/repos/simonw/datasette/issues/1497 | IC_kwDOBm6k_c44piA4 | simonw 9599 | 2021-10-24T23:06:05Z | 2021-10-24T23:06:05Z | OWNER | Right now the base image is: https://github.com/simonw/datasette/blob/e6e44372b34414eac2f36a4c1120af4f755aa423/Dockerfile#L1 I'm going to try `python:3.9.7-slim-buster` instead: https://hub.docker.com/layers/python/library/python/3.9.7-slim-buster/images/sha256-290b95e4b379762a9bd3d72644598e0972f4e2b5442bba60592c018fadcc744d?context=explore | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Publish to Docker Hub failing with "libcrypt.so.1: cannot open shared object file" 1034535001 | |
950411417 | https://github.com/simonw/datasette/issues/1497#issuecomment-950411417 | https://api.github.com/repos/simonw/datasette/issues/1497 | IC_kwDOBm6k_c44piCZ | simonw 9599 | 2021-10-24T23:06:45Z | 2021-10-24T23:11:14Z | OWNER | Same errors with `3.9.7`: ``` #5 41.46 /usr/bin/perl: error while loading shared libraries: libcrypt.so.1: cannot open shared object file: No such file or directory #5 41.46 dpkg: error processing package libc6:amd64 (--configure): #5 41.46 installed libc6:amd64 package post-installation script subprocess returned error exit status 127 #5 41.47 Errors were encountered while processing: #5 41.47 libc6:amd64 #5 41.50 E: Sub-process /usr/bin/dpkg returned an error code (1) ``` I'm suspicious of this part of the `Dockerfile`: https://github.com/simonw/datasette/blob/e6e44372b34414eac2f36a4c1120af4f755aa423/Dockerfile#L1-L18 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Publish to Docker Hub failing with "libcrypt.so.1: cannot open shared object file" 1034535001 | |
950411808 | https://github.com/simonw/datasette/issues/1497#issuecomment-950411808 | https://api.github.com/repos/simonw/datasette/issues/1497 | IC_kwDOBm6k_c44piIg | simonw 9599 | 2021-10-24T23:08:59Z | 2021-10-24T23:08:59Z | OWNER | Looks like it's this bug, reported on the Debian mailing list: https://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg1818037.html No obvious workaround there though. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Publish to Docker Hub failing with "libcrypt.so.1: cannot open shared object file" 1034535001 | |
950411912 | https://github.com/simonw/datasette/issues/1497#issuecomment-950411912 | https://api.github.com/repos/simonw/datasette/issues/1497 | IC_kwDOBm6k_c44piKI | simonw 9599 | 2021-10-24T23:09:41Z | 2021-10-24T23:09:41Z | OWNER | Here that is in the Debian bug tracker: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=993755 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Publish to Docker Hub failing with "libcrypt.so.1: cannot open shared object file" 1034535001 | |
950412628 | https://github.com/simonw/datasette/issues/1497#issuecomment-950412628 | https://api.github.com/repos/simonw/datasette/issues/1497 | IC_kwDOBm6k_c44piVU | simonw 9599 | 2021-10-24T23:13:20Z | 2021-10-24T23:13:27Z | OWNER | I think the root cause here is that I'm using a Debian Buster base image and then installing SpatiaLite from Debian unstable (sid) - as described in this comment: https://github.com/simonw/datasette/issues/1249#issuecomment-804309510 That's has worked fine in the past, but Sid is unstable - and this seems to be one of those instabilities. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Publish to Docker Hub failing with "libcrypt.so.1: cannot open shared object file" 1034535001 | |
950413185 | https://github.com/simonw/datasette/issues/1497#issuecomment-950413185 | https://api.github.com/repos/simonw/datasette/issues/1497 | IC_kwDOBm6k_c44pieB | simonw 9599 | 2021-10-24T23:16:25Z | 2021-10-24T23:18:30Z | OWNER | Debian stable these days is "bullseye" - https://www.debian.org/releases/ - which has the version of SpatiaLite that I was previously pulling in from Sid: https://packages.debian.org/bullseye/libsqlite3-mod-spatialite So upgrading to the 3.9.7-slim-bullseye base image may help. https://hub.docker.com/layers/python/library/python/3.9.7-slim-bullseye/images/sha256-67af5f544115124dc6d6da1d9d2815aa9825f6fd4aa6710adb0ec1725280fb89?context=explore | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Publish to Docker Hub failing with "libcrypt.so.1: cannot open shared object file" 1034535001 | |
950415822 | https://github.com/simonw/datasette/issues/1497#issuecomment-950415822 | https://api.github.com/repos/simonw/datasette/issues/1497 | IC_kwDOBm6k_c44pjHO | simonw 9599 | 2021-10-24T23:25:45Z | 2021-10-24T23:25:45Z | OWNER | I'm going to attempt to publish `0.59` to Docker Hub using https://github.com/simonw/datasette/blob/2c31d1cd9cd3b63458ccbe391866499fa3f44978/.github/workflows/push_docker_tag.yml - if that works I'll push `0.59.1` as well. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Publish to Docker Hub failing with "libcrypt.so.1: cannot open shared object file" 1034535001 | |
950416061 | https://github.com/simonw/datasette/issues/1497#issuecomment-950416061 | https://api.github.com/repos/simonw/datasette/issues/1497 | IC_kwDOBm6k_c44pjK9 | simonw 9599 | 2021-10-24T23:27:18Z | 2021-10-24T23:27:18Z | OWNER | That worked: https://hub.docker.com/layers/datasetteproject/datasette/0.59/images/sha256-038decc28e0ea84b281ecc0058fe8eba7aa99596e5a2177ff714092ad03294ed?context=explore | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Publish to Docker Hub failing with "libcrypt.so.1: cannot open shared object file" 1034535001 | |
950416460 | https://github.com/simonw/datasette/issues/1497#issuecomment-950416460 | https://api.github.com/repos/simonw/datasette/issues/1497 | IC_kwDOBm6k_c44pjRM | simonw 9599 | 2021-10-24T23:30:10Z | 2021-10-24T23:30:10Z | OWNER | Testing that newly published image: ``` % docker run -p 8002:8001 -v `pwd`:/mnt \ datasetteproject/datasette:0.59 datasette -p 8001 -h 0.0.0.0 /mnt/fixtures.db Unable to find image 'datasetteproject/datasette:0.59' locally 0.59: Pulling from datasetteproject/datasette 7d63c13d9b9b: Already exists 6ad2a11ca37b: Already exists e9edbe81a001: Already exists 36629b83aba2: Already exists 7338abefe51c: Already exists 6d71b6b88b82: Pull complete 8c4da3c56bdc: Pull complete Digest: sha256:038decc28e0ea84b281ecc0058fe8eba7aa99596e5a2177ff714092ad03294ed Status: Downloaded newer image for datasetteproject/datasette:0.59 INFO: Started server process [1] INFO: Waiting for application startup. INFO: Application startup complete. INFO: Uvicorn running on http://0.0.0.0:8001 (Press CTRL+C to quit) ``` and `http://localhost:8002/versions.json` returns: ```json { "python": { "version": "3.9.7", "full": "3.9.7 (default, Oct 12 2021, 02:43:43) \n[GCC 10.2.1 20210110]" }, "datasette": { "version": "0.59" }, "asgi": "3.0", "uvicorn": "0.15.0", "sqlite": { "version": "3.34.1" ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Publish to Docker Hub failing with "libcrypt.so.1: cannot open shared object file" 1034535001 | |
950416659 | https://github.com/simonw/datasette/issues/1497#issuecomment-950416659 | https://api.github.com/repos/simonw/datasette/issues/1497 | IC_kwDOBm6k_c44pjUT | simonw 9599 | 2021-10-24T23:31:41Z | 2021-10-24T23:31:41Z | OWNER | Published `0.59.1` as well: https://github.com/simonw/datasette/runs/3991214225?check_suite_focus=true Result: https://hub.docker.com/layers/datasetteproject/datasette/0.59.1/images/sha256-dc134f65bec40ed4ea7049188fe1e3915b8e6c3fd999b17effe8ec24868b979c?context=explore | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Publish to Docker Hub failing with "libcrypt.so.1: cannot open shared object file" 1034535001 | |
950416682 | https://github.com/simonw/datasette/issues/1497#issuecomment-950416682 | https://api.github.com/repos/simonw/datasette/issues/1497 | IC_kwDOBm6k_c44pjUq | simonw 9599 | 2021-10-24T23:31:51Z | 2021-10-24T23:31:51Z | OWNER | One catch: the `latest` tag on Docker Hub is still three months old. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Publish to Docker Hub failing with "libcrypt.so.1: cannot open shared object file" 1034535001 | |
950416802 | https://github.com/simonw/datasette/issues/1497#issuecomment-950416802 | https://api.github.com/repos/simonw/datasette/issues/1497 | IC_kwDOBm6k_c44pjWi | simonw 9599 | 2021-10-24T23:32:39Z | 2021-10-24T23:32:39Z | OWNER | That's because the `publish.yml` workflow ends with this, which isn't in the `push_docker_tag.yml` workflow: https://github.com/simonw/datasette/blob/2c31d1cd9cd3b63458ccbe391866499fa3f44978/.github/workflows/publish.yml#L117-L119 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Publish to Docker Hub failing with "libcrypt.so.1: cannot open shared object file" 1034535001 | |
950417375 | https://github.com/simonw/datasette/issues/1497#issuecomment-950417375 | https://api.github.com/repos/simonw/datasette/issues/1497 | IC_kwDOBm6k_c44pjff | simonw 9599 | 2021-10-24T23:36:54Z | 2021-10-24T23:36:54Z | OWNER | Tried fixing this by pushing a new `latest` tag from my laptop: ``` (datasette) datasette % docker pull datasetteproject/datasette:0.59.1 0.59.1: Pulling from datasetteproject/datasette 7d63c13d9b9b: Already exists 6ad2a11ca37b: Already exists e9edbe81a001: Already exists 36629b83aba2: Already exists 7338abefe51c: Already exists 6b825daddc6c: Pull complete d7508b065a21: Pull complete Digest: sha256:dc134f65bec40ed4ea7049188fe1e3915b8e6c3fd999b17effe8ec24868b979c Status: Downloaded newer image for datasetteproject/datasette:0.59.1 docker.io/datasetteproject/datasette:0.59.1 (datasette) datasette % docker tag datasetteproject/datasette:0.59.1 datasetteproject/datasette:latest (datasette) datasette % docker push datasetteproject/datasette:latest The push refers to repository [docker.io/datasetteproject/datasette] d668c99b6ff1: Layer already exists aa20c9013575: Layer already exists c97eebf2b227: Layer already exists 284a6c64b82c: Layer already exists 388eedeb736e: Layer already exists 2feece0964b8: Layer already exists e8b689711f21: Layer already exists errors: denied: requested access to the resource is denied unauthorized: authentication required ``` So I logged in with `docker login`: ``` (datasette) datasette % docker login Login with your Docker ID to push and pull images from Docker Hub. If you don't have a Docker ID, head over to https://hub.docker.com to create one. Username: datasetteproject Password: ``` And ran the push again and it worked: ``` (datasette) datasette % docker push datasetteproject/datasette:latest The push refers to repository [docker.io/datasetteproject/datasette] d668c99b6ff1: Layer already exists aa20c9013575: Layer already exists c97eebf2b227: Layer already exists 284a6c64b82c: Layer already exists 388eedeb736e: Layer already exists 2feece0964b8: Layer already exists e8b689711f21: Layer already exists latest: digest: sha256:dc134f65bec40ed4ea7049188fe1e3915b8e6c3fd999b17effe8ec24868b979c size: 1793 ``` https://hub.do… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Publish to Docker Hub failing with "libcrypt.so.1: cannot open shared object file" 1034535001 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
created_at (date) 2 ✖