issue_comments
18 rows where "updated_at" is on date 2020-06-28 sorted by created_at
This data as json, CSV (advanced)
id | html_url | issue_url | node_id | user | created_at ▼ | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
643657067 | https://github.com/simonw/datasette/issues/834#issuecomment-643657067 | https://api.github.com/repos/simonw/datasette/issues/834 | MDEyOklzc3VlQ29tbWVudDY0MzY1NzA2Nw== | simonw 9599 | 2020-06-13T17:59:42Z | 2020-06-28T04:01:52Z | OWNER | Documentation: https://datasette.readthedocs.io/en/latest/plugin_hooks.html#startup-datasette | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | startup() plugin hook 637342551 | |
650600176 | https://github.com/simonw/datasette/pull/869#issuecomment-650600176 | https://api.github.com/repos/simonw/datasette/issues/869 | MDEyOklzc3VlQ29tbWVudDY1MDYwMDE3Ng== | codecov[bot] 22429695 | 2020-06-27T18:41:31Z | 2020-06-28T02:54:21Z | NONE | # [Codecov](https://codecov.io/gh/simonw/datasette/pull/869?src=pr&el=h1) Report > Merging [#869](https://codecov.io/gh/simonw/datasette/pull/869?src=pr&el=desc) into [master](https://codecov.io/gh/simonw/datasette/commit/1bb33dab49fd25f77b9f8e7ab7ee23b3d64c123c&el=desc) will **increase** coverage by `0.23%`. > The diff coverage is `90.62%`. [![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/869/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1)](https://codecov.io/gh/simonw/datasette/pull/869?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #869 +/- ## ========================================== + Coverage 82.99% 83.23% +0.23% ========================================== Files 26 27 +1 Lines 3547 3609 +62 ========================================== + Hits 2944 3004 +60 - Misses 603 605 +2 ``` | [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/869?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [datasette/plugins.py](https://codecov.io/gh/simonw/datasette/pull/869/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL3BsdWdpbnMucHk=) | `82.35% <ø> (ø)` | | | [datasette/views/database.py](https://codecov.io/gh/simonw/datasette/pull/869/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL3ZpZXdzL2RhdGFiYXNlLnB5) | `96.45% <86.36%> (-1.88%)` | :arrow_down: | | [datasette/default\_magic\_parameters.py](https://codecov.io/gh/simonw/datasette/pull/869/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL2RlZmF1bHRfbWFnaWNfcGFyYW1ldGVycy5weQ==) | `91.17% <91.17%> (ø)` | | | [datasette/app.py](https://codecov.io/gh/simonw/datasette/pull/869/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL2FwcC5weQ==) | `96.07% <100.00%> (+0.81%)` | :arrow_up: | | [datasette/hookspecs.py](https://codecov.io/gh/simonw/datasette/pull/869/diff?src=pr&el=tree#diff-ZGF0YXNldHRlL2hvb2tzcGVjcy5weQ==) | `100.00% <100.00%> (ø)` | | | [datasette/utils/\_\_init\_\_.py](https://codecov.io/gh/simonw/dataset… | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Magic parameters for canned queries 646734280 | |
650678951 | https://github.com/simonw/datasette/issues/842#issuecomment-650678951 | https://api.github.com/repos/simonw/datasette/issues/842 | MDEyOklzc3VlQ29tbWVudDY1MDY3ODk1MQ== | simonw 9599 | 2020-06-28T02:59:52Z | 2020-06-28T02:59:52Z | OWNER | Documentation: https://datasette.readthedocs.io/en/latest/sql_queries.html#magic-parameters Plugin hook documentation: https://datasette.readthedocs.io/en/latest/plugin_hooks.html#plugin-hook-register-magic-parameters | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Magic parameters for canned queries 638212085 | |
650679100 | https://github.com/simonw/datasette/issues/842#issuecomment-650679100 | https://api.github.com/repos/simonw/datasette/issues/842 | MDEyOklzc3VlQ29tbWVudDY1MDY3OTEwMA== | simonw 9599 | 2020-06-28T03:00:44Z | 2020-06-28T03:00:44Z | OWNER | I'm going to add some canned queries to the `metadata.json` used by the live demo that illustrate this feature. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Magic parameters for canned queries 638212085 | |
650681496 | https://github.com/simonw/datasette/issues/805#issuecomment-650681496 | https://api.github.com/repos/simonw/datasette/issues/805 | MDEyOklzc3VlQ29tbWVudDY1MDY4MTQ5Ng== | simonw 9599 | 2020-06-28T03:11:51Z | 2020-06-28T03:11:51Z | OWNER | I can use magic parameters from #842 in this. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Writable canned queries live demo on Glitch 632724154 | |
650684635 | https://github.com/simonw/datasette/issues/842#issuecomment-650684635 | https://api.github.com/repos/simonw/datasette/issues/842 | MDEyOklzc3VlQ29tbWVudDY1MDY4NDYzNQ== | simonw 9599 | 2020-06-28T03:30:31Z | 2020-06-28T03:30:31Z | OWNER | Live demo: https://latest.datasette.io/fixtures/magic_parameters | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Magic parameters for canned queries 638212085 | |
650784162 | https://github.com/simonw/datasette/issues/805#issuecomment-650784162 | https://api.github.com/repos/simonw/datasette/issues/805 | MDEyOklzc3VlQ29tbWVudDY1MDc4NDE2Mg== | simonw 9599 | 2020-06-28T15:48:32Z | 2020-06-28T15:48:32Z | OWNER | https://github.com/simonw/datasette-glitch is my new plugin that outputs the root login link on Glitch when the server starts. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Writable canned queries live demo on Glitch 632724154 | |
650811919 | https://github.com/simonw/datasette/issues/834#issuecomment-650811919 | https://api.github.com/repos/simonw/datasette/issues/834 | MDEyOklzc3VlQ29tbWVudDY1MDgxMTkxOQ== | simonw 9599 | 2020-06-28T19:38:50Z | 2020-06-28T19:38:50Z | OWNER | I have two plugins in progress that use this hook now: - https://github.com/simonw/datasette-init creates tables and views on startup - https://github.com/simonw/datasette-glitch outputs the login-as-root secret link on Glitch | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | startup() plugin hook 637342551 | |
650812444 | https://github.com/simonw/datasette/issues/871#issuecomment-650812444 | https://api.github.com/repos/simonw/datasette/issues/871 | MDEyOklzc3VlQ29tbWVudDY1MDgxMjQ0NA== | simonw 9599 | 2020-06-28T19:43:27Z | 2020-06-28T19:43:27Z | OWNER | Currently: > `_timestamp_epoch` > > The number of seconds since the Unix epoch. > > `_timestamp_date_utc` > > The date in UTC, e.g. `2020-06-01` > > `_timestamp_datetime_utc` > > The ISO 8601 datetime in UTC, e.g. `2020-06-24T18:01:07Z` I'm going to rename them to: - `_now_epoch` - `_now_date_utc` - `_now_datetime_utc` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Rename the _timestamp magic parameters to _now 646840273 | |
650815278 | https://github.com/simonw/datasette/issues/870#issuecomment-650815278 | https://api.github.com/repos/simonw/datasette/issues/870 | MDEyOklzc3VlQ29tbWVudDY1MDgxNTI3OA== | simonw 9599 | 2020-06-28T20:09:07Z | 2020-06-28T20:11:21Z | OWNER | There's a lot of complex logic in the `DataView` class, which handles conditionally returning content as `.json` or as HTML or as `.csv`. That view subclasses `AsgiView` which is itself request-aware, so maybe I don't need to reconsider how those classes work - just figure out how to hook them up with `register_routes`. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Refactor default views to use register_routes 646737558 | |
650818086 | https://github.com/simonw/datasette/issues/870#issuecomment-650818086 | https://api.github.com/repos/simonw/datasette/issues/870 | MDEyOklzc3VlQ29tbWVudDY1MDgxODA4Ng== | simonw 9599 | 2020-06-28T20:34:33Z | 2020-06-28T20:34:33Z | OWNER | The key to all of this may be the `DatasetteRouter` class. It deals with `scope` right now but if it internally dealt with `request` that could be enough to fix #864 by adding logic needed by the `.add_message()` mechanism. https://github.com/simonw/datasette/blob/0991ea75cc7b265389aa8362414a305ba532d31a/datasette/app.py#L904-L938 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Refactor default views to use register_routes 646737558 | |
650818309 | https://github.com/simonw/datasette/issues/870#issuecomment-650818309 | https://api.github.com/repos/simonw/datasette/issues/870 | MDEyOklzc3VlQ29tbWVudDY1MDgxODMwOQ== | simonw 9599 | 2020-06-28T20:36:28Z | 2020-06-28T20:36:52Z | OWNER | Since `AsgiRouter` is only used as the super-class of the `DatasetteRouter` class maybe I should get rid of `AsgiRouter` entirely - no point in having a Datasette-specific subclass of it if the parent class isn't ever used by anything else. I could also rename it to just `Router` which is a nicer name than `DatasetteRouter`. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Refactor default views to use register_routes 646737558 | |
650819895 | https://github.com/simonw/datasette/issues/847#issuecomment-650819895 | https://api.github.com/repos/simonw/datasette/issues/847 | MDEyOklzc3VlQ29tbWVudDY1MDgxOTg5NQ== | simonw 9599 | 2020-06-28T20:50:21Z | 2020-06-28T20:50:21Z | OWNER | I'm happy enough with https://codecov.io/gh/simonw/datasette that I'm not going to spend any more time on this. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Take advantage of .coverage being a SQLite database 638259643 | |
650820068 | https://github.com/simonw/datasette/issues/870#issuecomment-650820068 | https://api.github.com/repos/simonw/datasette/issues/870 | MDEyOklzc3VlQ29tbWVudDY1MDgyMDA2OA== | simonw 9599 | 2020-06-28T20:52:09Z | 2020-06-28T20:53:00Z | OWNER | Maybe I could add a `as_request_view` method as an alternative to `as_asgi`: https://github.com/simonw/datasette/blob/a8bcafc1775c8a8655b365ae22a3d64f6361c74a/datasette/utils/asgi.py#L150-L174 Or I could teach the `Router` to spot the `dispatch_request` method and call it directly. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Refactor default views to use register_routes 646737558 | |
650834251 | https://github.com/simonw/datasette/issues/870#issuecomment-650834251 | https://api.github.com/repos/simonw/datasette/issues/870 | MDEyOklzc3VlQ29tbWVudDY1MDgzNDI1MQ== | simonw 9599 | 2020-06-28T23:03:28Z | 2020-06-28T23:03:28Z | OWNER | I'm going to ditch that `AsgiView` class too, by combining it into `BaseView`. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Refactor default views to use register_routes 646737558 | |
650834666 | https://github.com/simonw/datasette/issues/870#issuecomment-650834666 | https://api.github.com/repos/simonw/datasette/issues/870 | MDEyOklzc3VlQ29tbWVudDY1MDgzNDY2Ng== | simonw 9599 | 2020-06-28T23:07:19Z | 2020-06-28T23:07:19Z | OWNER | So now the problem is simpler: I need to get `BaseView` to a state where it can accept a shared `request` object and it can be used in conjunction with `register_routes()`. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Refactor default views to use register_routes 646737558 | |
650838691 | https://github.com/simonw/datasette/issues/870#issuecomment-650838691 | https://api.github.com/repos/simonw/datasette/issues/870 | MDEyOklzc3VlQ29tbWVudDY1MDgzODY5MQ== | simonw 9599 | 2020-06-28T23:44:12Z | 2020-06-28T23:44:25Z | OWNER | This code is interesting: https://github.com/simonw/datasette/blob/3bc2461c77ecba3e1a95301dd440a9bef56b1283/datasette/app.py#L948-L955 I want to change the signature of that `return await view(new_scope, receive, send)` method to instead take `(request, send)` - so I can have a single shared request object that's created just once per HTTP request. The problem is the scope modification: I have code that modifies the scope, but how should that impact a shared `Request` instance? Should its `.scope` be replaced with alternative scopes as it travels through the codebase? | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Refactor default views to use register_routes 646737558 | |
650838972 | https://github.com/simonw/datasette/issues/870#issuecomment-650838972 | https://api.github.com/repos/simonw/datasette/issues/870 | MDEyOklzc3VlQ29tbWVudDY1MDgzODk3Mg== | simonw 9599 | 2020-06-28T23:46:40Z | 2020-06-28T23:46:40Z | OWNER | I'm going to create the single `Request()` instance in the `DatasetteRouter` class - at the beginning of the `route_path` method: https://github.com/simonw/datasette/blob/3bc2461c77ecba3e1a95301dd440a9bef56b1283/datasette/app.py#L905-L925 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Refactor default views to use register_routes 646737558 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
created_at (date) 3 ✖