issue_comments
7 rows where "updated_at" is on date 2022-03-14 sorted by body
This data as json, CSV (advanced)
Suggested facets: reactions
id | html_url | issue_url | node_id | user | created_at | updated_at | author_association | body ▼ | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
1066222323 | https://github.com/simonw/datasette/issues/1384#issuecomment-1066222323 | https://api.github.com/repos/simonw/datasette/issues/1384 | IC_kwDOBm6k_c4_jULz | brandonrobertz 2670795 | 2022-03-14T00:36:42Z | 2022-03-14T00:36:42Z | CONTRIBUTOR | > Ah, sorry, I didn't get what you were saying you the first time. Using _metadata_local in that way makes total sense -- I agree, refreshing metadata each cell was seeming quite excessive. Now I'm on the same page! :) All good. Report back any issues you find with this stuff. Metadata/dynamic config hasn't been tested widely outside of what I've done AFAIK. If you find a strong use case for async meta, it's going to be better to know sooner rather than later! | {"total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Plugin hook for dynamic metadata 930807135 | |
1067414156 | https://github.com/simonw/datasette/issues/1657#issuecomment-1067414156 | https://api.github.com/repos/simonw/datasette/issues/1657 | IC_kwDOBm6k_c4_n3KM | simonw 9599 | 2022-03-14T23:38:41Z | 2022-03-14T23:38:41Z | OWNER | And in https://datatracker.ietf.org/doc/html/rfc3986#section-2.3 "Unreserved Characters": unreserved = ALPHA / DIGIT / "-" / "." / "_" / "~" | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Tilde encoding: use ~ instead of - for dash-encoding 1168995756 | |
1067382232 | https://github.com/simonw/datasette/issues/1657#issuecomment-1067382232 | https://api.github.com/repos/simonw/datasette/issues/1657 | IC_kwDOBm6k_c4_nvXY | simonw 9599 | 2022-03-14T22:58:47Z | 2022-03-14T22:58:47Z | OWNER | Asked about this [on Twitter](https://twitter.com/simonw/status/1503499169775849473): > Anyone ever seen a proxy or other URL handling system do anything surprising with the tilde "~" character? > > I'm considering it as an escaping character, in place of "-" as described in Replies so far seem like it should be OK - Apache has supported this for home directories for a couple of decades now without any problems. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Tilde encoding: use ~ instead of - for dash-encoding 1168995756 | |
1067413691 | https://github.com/simonw/datasette/issues/1657#issuecomment-1067413691 | https://api.github.com/repos/simonw/datasette/issues/1657 | IC_kwDOBm6k_c4_n3C7 | simonw 9599 | 2022-03-14T23:37:42Z | 2022-03-14T23:37:42Z | OWNER | Relevant: https://datatracker.ietf.org/doc/html/rfc3986#section-2.1 ``` reserved = gen-delims / sub-delims gen-delims = ":" / "/" / "?" / "#" / "[" / "]" / "@" sub-delims = "!" / "$" / "&" / "'" / "(" / ")" / "*" / "+" / "," / ";" / "=" ``` Notably `~` is not in either of those lists. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Tilde encoding: use ~ instead of - for dash-encoding 1168995756 | |
1067381556 | https://github.com/simonw/datasette/issues/1657#issuecomment-1067381556 | https://api.github.com/repos/simonw/datasette/issues/1657 | IC_kwDOBm6k_c4_nvM0 | simonw 9599 | 2022-03-14T22:57:27Z | 2022-03-14T22:57:45Z | OWNER | The problem with the [dash encoding mechanism](https://simonwillison.net/2022/Mar/5/dash-encoding/) is that it turns out dashes are used in a LOT of existing Datasette instances - much of https://fivethirtyeight.datasettes.com/fivethirtyeight for example, and even https://datasette.io/ itself: https://datasette.io/dogsheep-index It's pretty ugly to force all of those to change to their dash-encoded equivalent - and in fact it broke https://datasette.io/ in a subtle way: - https://github.com/simonw/datasette.io/issues/94 I'm going to try using `~` instead and see if that works as well and causes less breakage to existing sites. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Tilde encoding: use ~ instead of - for dash-encoding 1168995756 | |
1067382442 | https://github.com/simonw/datasette/issues/1651#issuecomment-1067382442 | https://api.github.com/repos/simonw/datasette/issues/1651 | IC_kwDOBm6k_c4_nvaq | simonw 9599 | 2022-03-14T22:59:10Z | 2022-03-14T22:59:10Z | OWNER | This work is now blocked on: - https://github.com/simonw/datasette/issues/1657 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Get rid of the no-longer necessary ?_format=json hack for tables called x.json 1161584460 | |
1067423720 | https://github.com/simonw/datasette/issues/1657#issuecomment-1067423720 | https://api.github.com/repos/simonw/datasette/issues/1657 | IC_kwDOBm6k_c4_n5fo | simonw 9599 | 2022-03-14T23:59:56Z | 2022-03-14T23:59:56Z | OWNER | Updated test: ```python @pytest.mark.parametrize( "original,expected", ( ("abc", "abc"), ("/foo/bar", "~2Ffoo~2Fbar"), ("/-/bar", "~2F-~2Fbar"), ("-/db-/table.csv", "-~2Fdb-~2Ftable~2Ecsv"), (r"%~-/", "~25~7E-~2F"), ("~25~7E~2D~2F", "~7E25~7E7E~7E2D~7E2F"), ), ) def test_tilde_encoding(original, expected): actual = utils.tilde_encode(original) assert actual == expected # And test round-trip assert original == utils.tilde_decode(actual) ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Tilde encoding: use ~ instead of - for dash-encoding 1168995756 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
updated_at (date) 1 ✖