issue_comments

Table actions

2 rows where author_association = "OWNER" and "created_at" is on date 2019-12-01

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

id ▼ html_url issue_url node_id user created_at updated_at author_association body reactions issue performed_via_github_app
560036585 https://github.com/simonw/datasette/issues/645#issuecomment-560036585 https://api.github.com/repos/simonw/datasette/issues/645 MDEyOklzc3VlQ29tbWVudDU2MDAzNjU4NQ== simonw 9599 2019-12-01T01:28:35Z 2019-12-01T01:28:35Z OWNER Plugins are currently expected to return this: ```python @hookimpl def register_output_renderer(datasette): return { "extension": "test", "callback": render_test } ``` We can add an optional third argument, `"should_suggest"`, which takes the same arguments as the callback but simply returns `True` or `False` depending on if the plugin can work for the current set of data. If that dictionary key is omitted, Datasette will treat this test as returning `True`. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Mechanism for register_output_renderer to suggest extension or not 530653633  
560036740 https://github.com/simonw/datasette/issues/645#issuecomment-560036740 https://api.github.com/repos/simonw/datasette/issues/645 MDEyOklzc3VlQ29tbWVudDU2MDAzNjc0MA== simonw 9599 2019-12-01T01:29:58Z 2019-12-01T01:29:58Z OWNER It should be optionally awaitable - as should the existing `"callback"`. Can use the same pattern as this one: https://github.com/simonw/datasette/blob/8c642f04e0608bf537fdd1f76d64c2367fb04d57/datasette/views/base.py#L124-L135 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Mechanism for register_output_renderer to suggest extension or not 530653633  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);