home / github

Menu
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

4 rows where issue = 1087919372

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

id ▼ html_url issue_url node_id user created_at updated_at author_association body reactions issue performed_via_github_app
1000469107 https://github.com/simonw/datasette/issues/1578#issuecomment-1000469107 https://api.github.com/repos/simonw/datasette/issues/1578 IC_kwDOBm6k_c47ofJz simonw 9599 2021-12-23T18:36:38Z 2021-12-23T18:36:38Z OWNER This problem doesn't occur on my `localhost` running Uvicorn directly - but I'm seeing it in my production environment that runs Datasette behind an nginx proxy: ``` location / { proxy_pass http://127.0.0.1:8000/; proxy_set_header Host $host; } ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Confirm if documented nginx proxy config works for row pages with escaped characters in their primary key 1087919372  
1000470652 https://github.com/simonw/datasette/issues/1578#issuecomment-1000470652 https://api.github.com/repos/simonw/datasette/issues/1578 IC_kwDOBm6k_c47ofh8 simonw 9599 2021-12-23T18:40:46Z 2021-12-23T18:40:46Z OWNER [This StackOverflow answer](https://serverfault.com/a/463932) suggests that the fix is to change this: proxy_pass http://127.0.0.1:8000/; To this: proxy_pass http://127.0.0.1:8000; Quoting the nginx documentation: http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_pass > A request URI is passed to the server as follows: > > - If the `proxy_pass` directive is specified with a URI, then when a request is passed to the server, the part of a [normalized](http://nginx.org/en/docs/http/ngx_http_core_module.html#location) request URI matching the location is replaced by a URI specified in the directive: > > location /name/ { > proxy_pass http://127.0.0.1/remote/; > } > > - If `proxy_pass` is specified without a URI, the request URI is passed to the server in the same form as sent by a client when the original request is processed, or the full normalized request URI is passed when processing the changed URI: > > location /some/path/ { > proxy_pass http://127.0.0.1; > } {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Confirm if documented nginx proxy config works for row pages with escaped characters in their primary key 1087919372  
1000471371 https://github.com/simonw/datasette/issues/1578#issuecomment-1000471371 https://api.github.com/repos/simonw/datasette/issues/1578 IC_kwDOBm6k_c47oftL simonw 9599 2021-12-23T18:42:50Z 2021-12-23T18:42:50Z OWNER Confirmed, that fixed the bug for me on my server. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Confirm if documented nginx proxy config works for row pages with escaped characters in their primary key 1087919372  
1000471782 https://github.com/simonw/datasette/issues/1578#issuecomment-1000471782 https://api.github.com/repos/simonw/datasette/issues/1578 IC_kwDOBm6k_c47ofzm simonw 9599 2021-12-23T18:44:01Z 2021-12-23T18:44:01Z OWNER The example nginx config on https://docs.datasette.io/en/stable/deploying.html#nginx-proxy-configuration is currently: ``` daemon off; events { worker_connections 1024; } http { server { listen 80; location /my-datasette { proxy_pass http://127.0.0.1:8009/my-datasette; proxy_set_header Host $host; } } } ``` This looks to me like it might exhibit the bug. Need to confirm that and figure out an alternative. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Confirm if documented nginx proxy config works for row pages with escaped characters in their primary key 1087919372  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 22.649ms · About: simonw/datasette-graphql