issue_comments
19 rows where issue = 1108235694
This data as json, CSV (advanced)
Suggested facets: created_at (date), updated_at (date)
| id ▼ | html_url | issue_url | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
|---|---|---|---|---|---|---|---|---|---|---|---|
| 1016579661 | https://github.com/simonw/datasette/issues/1603#issuecomment-1016579661 | https://api.github.com/repos/simonw/datasette/issues/1603 | IC_kwDOBm6k_c48l8ZN | simonw 9599 | 2022-01-19T15:27:05Z | 2022-01-19T15:27:05Z | OWNER | I'd like this to be customizable. I'm going to load it from the template loading system such that a custom favicon for a specific instance can be dropped in using a file in `templates/`. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | A proper favicon 1108235694 | |
| 1016588326 | https://github.com/simonw/datasette/issues/1603#issuecomment-1016588326 | https://api.github.com/repos/simonw/datasette/issues/1603 | IC_kwDOBm6k_c48l-gm | simonw 9599 | 2022-01-19T15:35:33Z | 2022-01-19T15:35:33Z | OWNER | I don't think abusing the template loader mechanism for this will work: Jinja provides an API for loading text templates, but I don't think it can be sensibly abused to open binary image files instead. Loaded code is here: https://github.com/pallets/jinja/blob/main/src/jinja2/loaders.py | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | A proper favicon 1108235694 | |
| 1016589140 | https://github.com/simonw/datasette/issues/1603#issuecomment-1016589140 | https://api.github.com/repos/simonw/datasette/issues/1603 | IC_kwDOBm6k_c48l-tU | simonw 9599 | 2022-01-19T15:36:16Z | 2022-01-19T15:36:16Z | OWNER | For the moment then I will hard-code a new favicon and leave it to ASGI plugins if people want to define their own. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | A proper favicon 1108235694 | |
| 1016589519 | https://github.com/simonw/datasette/issues/1603#issuecomment-1016589519 | https://api.github.com/repos/simonw/datasette/issues/1603 | IC_kwDOBm6k_c48l-zP | simonw 9599 | 2022-01-19T15:36:38Z | 2022-01-19T15:36:38Z | OWNER | Also people can use a custom base template and link to a custom favicon if they want to. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | A proper favicon 1108235694 | |
| 1017131209 | https://github.com/simonw/datasette/issues/1603#issuecomment-1017131209 | https://api.github.com/repos/simonw/datasette/issues/1603 | IC_kwDOBm6k_c48oDDJ | simonw 9599 | 2022-01-20T05:22:40Z | 2022-01-20T05:22:40Z | OWNER | This one is 101KB and 1536*1536 which is a bit big! https://github.com/simonw/datasette-app/blob/main/build/icon.png | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | A proper favicon 1108235694 | |
| 1017131801 | https://github.com/simonw/datasette/issues/1603#issuecomment-1017131801 | https://api.github.com/repos/simonw/datasette/issues/1603 | IC_kwDOBm6k_c48oDMZ | simonw 9599 | 2022-01-20T05:23:57Z | 2022-01-20T05:23:57Z | OWNER | https://adamj.eu/tech/2022/01/18/how-to-add-a-favicon-to-your-django-site/ suggests 64x64, I'm going with 128x128 just in case anyone invents a retina-retina screen. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | A proper favicon 1108235694 | |
| 1017132927 | https://github.com/simonw/datasette/issues/1603#issuecomment-1017132927 | https://api.github.com/repos/simonw/datasette/issues/1603 | IC_kwDOBm6k_c48oDd_ | simonw 9599 | 2022-01-20T05:26:29Z | 2022-01-20T05:26:29Z | OWNER | Here's the 128x128 one - 11kb, I resized it using Preview:  Now running it through [Squoosh](https://squoosh.app/editor) using OxiPNG effort=3 colours=24 - brought it down to 1.36KB.  | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | A proper favicon 1108235694 | |
| 1017133357 | https://github.com/simonw/datasette/issues/1603#issuecomment-1017133357 | https://api.github.com/repos/simonw/datasette/issues/1603 | IC_kwDOBm6k_c48oDkt | simonw 9599 | 2022-01-20T05:27:34Z | 2022-01-20T05:27:34Z | OWNER | I'm going to drop it in `datasette/static/favicon.png` and rewrite the `async def favicon()` function to return it, with caching headers. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | A proper favicon 1108235694 | |
| 1017136897 | https://github.com/simonw/datasette/issues/1603#issuecomment-1017136897 | https://api.github.com/repos/simonw/datasette/issues/1603 | IC_kwDOBm6k_c48oEcB | simonw 9599 | 2022-01-20T05:36:29Z | 2022-01-20T05:36:29Z | OWNER | Here's what it looks like in Firefox, Chrome and Safari:  | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | A proper favicon 1108235694 | |
| 1017137117 | https://github.com/simonw/datasette/issues/1603#issuecomment-1017137117 | https://api.github.com/repos/simonw/datasette/issues/1603 | IC_kwDOBm6k_c48oEfd | simonw 9599 | 2022-01-20T05:37:05Z | 2022-01-20T05:37:34Z | OWNER | I'm not crazy about the look - I think this version of the grid may have too many lines for this particular display size. I'm going to try reducing the number of lines in Figma to see if I like that better. https://www.figma.com/file/LKjceTFNtKm6wCbScDqm1Y/Datasette-Logo | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | A proper favicon 1108235694 | |
| 1017139321 | https://github.com/simonw/datasette/issues/1603#issuecomment-1017139321 | https://api.github.com/repos/simonw/datasette/issues/1603 | IC_kwDOBm6k_c48oFB5 | simonw 9599 | 2022-01-20T05:43:07Z | 2022-01-20T05:46:42Z | OWNER | My attempt with one less grid line looked awful when shrunk down to the browser size: <img width="350" alt="image" src="https://user-images.githubusercontent.com/9599/150280445-a482de8e-8b5f-4145-8567-36ac7105c303.png"> File here:  I'm going with the first attempt for the moment. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | A proper favicon 1108235694 | |
| 1017142395 | https://github.com/simonw/datasette/issues/1603#issuecomment-1017142395 | https://api.github.com/repos/simonw/datasette/issues/1603 | IC_kwDOBm6k_c48oFx7 | simonw 9599 | 2022-01-20T05:50:55Z | 2022-01-20T05:50:55Z | OWNER | The new `/favicon.ico` view: https://github.com/simonw/datasette/blob/0467723ee57c2cbc0f02daa47cef632dd4651df0/datasette/app.py#L182-L192 | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | A proper favicon 1108235694 | |
| 1017143437 | https://github.com/simonw/datasette/issues/1603#issuecomment-1017143437 | https://api.github.com/repos/simonw/datasette/issues/1603 | IC_kwDOBm6k_c48oGCN | simonw 9599 | 2022-01-20T05:53:17Z | 2022-01-20T05:53:17Z | OWNER | New favicon now live on https://latest.datasette.io/ - see also https://latest.datasette.io/favicon.ico | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | A proper favicon 1108235694 | |
| 1017143817 | https://github.com/simonw/datasette/issues/1603#issuecomment-1017143817 | https://api.github.com/repos/simonw/datasette/issues/1603 | IC_kwDOBm6k_c48oGIJ | simonw 9599 | 2022-01-20T05:54:09Z | 2022-01-20T05:54:09Z | OWNER | Oops, I pushed the one I liked least out of the two options! Fixing now. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | A proper favicon 1108235694 | |
| 1017149828 | https://github.com/simonw/datasette/issues/1603#issuecomment-1017149828 | https://api.github.com/repos/simonw/datasette/issues/1603 | IC_kwDOBm6k_c48oHmE | simonw 9599 | 2022-01-20T06:07:31Z | 2022-01-20T06:07:31Z | OWNER | Now live on https://latest.datastte.io/ - I'm happy enough with this for the moment: <img width="364" alt="image" src="https://user-images.githubusercontent.com/9599/150283069-dd23e688-ec77-4200-a892-38e0f8892f30.png"> | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | A proper favicon 1108235694 | |
| 1017800506 | https://github.com/simonw/datasette/issues/1603#issuecomment-1017800506 | https://api.github.com/repos/simonw/datasette/issues/1603 | IC_kwDOBm6k_c48qmc6 | simonw 9599 | 2022-01-20T18:31:18Z | 2022-01-20T18:31:18Z | OWNER | One last go at tidying this up. I decided to do a 32x32 pixel version in Pixelmator, using this trick to access a pixel brush: https://osxdaily.com/2016/11/17/enable-pixel-brush-pixelmator-mac/ <img width="916" alt="image" src="https://user-images.githubusercontent.com/9599/150399724-10b17a97-3ecf-4d82-868c-f8a642f16838.png"> Frustrating how the white boxes are all exactly four pixels high and ALMOST all four pixels wide, but one of them has to be three pixels wide to fit the space. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | A proper favicon 1108235694 | |
| 1017806497 | https://github.com/simonw/datasette/issues/1603#issuecomment-1017806497 | https://api.github.com/repos/simonw/datasette/issues/1603 | IC_kwDOBm6k_c48qn6h | simonw 9599 | 2022-01-20T18:39:27Z | 2022-01-20T18:39:57Z | OWNER | Here's a comparison between my hand-edited version and the one I have now:  The new 32x32 image: <img src="https://user-images.githubusercontent.com/9599/150401295-8873fa40-8859-40e3-99d7-e53276319a15.png" width="32" height="32"> | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | A proper favicon 1108235694 | |
| 1017808898 | https://github.com/simonw/datasette/issues/1603#issuecomment-1017808898 | https://api.github.com/repos/simonw/datasette/issues/1603 | IC_kwDOBm6k_c48qogC | simonw 9599 | 2022-01-20T18:42:35Z | 2022-01-20T18:42:35Z | OWNER | Resized it down to 208 bytes with https://squoosh.app <img width="883" alt="image" src="https://user-images.githubusercontent.com/9599/150401693-d19c7fdf-7f5d-49b4-8f1e-5c9e62cbdbed.png">  | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | A proper favicon 1108235694 | |
| 1017842366 | https://github.com/simonw/datasette/issues/1603#issuecomment-1017842366 | https://api.github.com/repos/simonw/datasette/issues/1603 | IC_kwDOBm6k_c48qwq- | simonw 9599 | 2022-01-20T19:19:54Z | 2022-01-20T19:19:54Z | OWNER | Wrote up a TIL: https://til.simonwillison.net/pixelmator/pixel-editing-favicon | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | A proper favicon 1108235694 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] (
[html_url] TEXT,
[issue_url] TEXT,
[id] INTEGER PRIMARY KEY,
[node_id] TEXT,
[user] INTEGER REFERENCES [users]([id]),
[created_at] TEXT,
[updated_at] TEXT,
[author_association] TEXT,
[body] TEXT,
[reactions] TEXT,
[issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
ON [issue_comments] ([user]);