issue_comments
5 rows where issue = 1160407071
This data as json, CSV (advanced)
Suggested facets: created_at (date), updated_at (date)
| id ▼ | html_url | issue_url | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
|---|---|---|---|---|---|---|---|---|---|---|---|
| 1059804577 | https://github.com/simonw/datasette/issues/1647#issuecomment-1059804577 | https://api.github.com/repos/simonw/datasette/issues/1647 | IC_kwDOBm6k_c4_K1Wh | simonw 9599 | 2022-03-05T17:49:46Z | 2022-03-05T17:49:46Z | OWNER | My best guess is that this is an undocumented change in SQLite 3.38 - I get that test failure with that SQLite version. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Test failures with SQLite 3.37.0+ due to column affinity case 1160407071 | |
| 1059807598 | https://github.com/simonw/datasette/issues/1647#issuecomment-1059807598 | https://api.github.com/repos/simonw/datasette/issues/1647 | IC_kwDOBm6k_c4_K2Fu | simonw 9599 | 2022-03-05T18:06:56Z | 2022-03-05T18:08:00Z | OWNER | Had a look through the commits in https://github.com/sqlite/sqlite/compare/version-3.37.2...version-3.38.0 but couldn't see anything obvious that might have caused this. Really wish I had a good mechanism for running the test suite against different SQLite versions! May have to revisit this old trick: https://til.simonwillison.net/sqlite/ld-preload | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Test failures with SQLite 3.37.0+ due to column affinity case 1160407071 | |
| 1059819628 | https://github.com/simonw/datasette/issues/1647#issuecomment-1059819628 | https://api.github.com/repos/simonw/datasette/issues/1647 | IC_kwDOBm6k_c4_K5Bs | simonw 9599 | 2022-03-05T19:28:54Z | 2022-03-05T19:28:54Z | OWNER | OK, using that trick worked for testing this: docker run -it -p 8001:8001 ubuntu Then inside that container: apt-get install -y python3 build-essential tcl wget python3-pip git python3.8-venv For each version of SQLite I wanted to test I needed to figure out the tarball URL - for example, for `3.38.0` I navigated to https://www.sqlite.org/src/timeline?t=version-3.38.0 and clicked the "checkin" link and copied the tarball link: https://www.sqlite.org/src/tarball/40fa792d/SQLite-40fa792d.tar.gz Then to build it (the `CPPFLAGS` took some trial and error): ``` cd /tmp wget https://www.sqlite.org/src/tarball/40fa792d/SQLite-40fa792d.tar.gz tar -xzvf SQLite-40fa792d.tar.gz cd SQLite-40fa792d CPPFLAGS="-DSQLITE_ENABLE_FTS3 -DSQLITE_ENABLE_FTS3_PARENTHESIS -DSQLITE_ENABLE_RTREE=1" ./configure make ``` Then to test with Datasette: ``` cd /tmp git clone https://github.com/simonw/datasette cd datasette python3 -m venv venv source venv/bin/activate pip install wheel # So bdist_wheel works in next step pip install -e '.[test]' LD_PRELOAD=/tmp/SQLite-40fa792d/.libs/libsqlite3.so pytest ``` After some trial and error I proved that those tests passed with 3.36.0: ``` cd /tmp wget https://www.sqlite.org/src/tarball/5c9a6c06/SQLite-5c9a6c06.tar.gz tar -xzvf SQLite-5c9a6c06.tar.gz cd SQLite-5c9a6c06 CPPFLAGS="-DSQLITE_ENABLE_FTS3 -DSQLITE_ENABLE_FTS3_PARENTHESIS -DSQLITE_ENABLE_RTREE=1" ./configure make cd /tmp/datasette LD_PRELOAD=/tmp/SQLite-5c9a6c06/.libs/libsqlite3.so pytest tests/test_internals_database.py ``` BUT failed with 3.37.0: ``` # 3.37.0 cd /tmp wget https://www.sqlite.org/src/tarball/bd41822c/SQLite-bd41822c.tar.gz tar -xzvf SQLite-bd41822c.tar.gz cd SQLite-bd41822c CPPFLAGS="-DSQLITE_ENABLE_FTS3 -DSQLITE_ENABLE_FTS3_PARENTHESIS -DSQLITE_ENABLE_RTREE=1" ./configure make cd /tmp/datasette LD_PRELOAD=/tmp/SQLite-bd41822c/.libs/libsqlite3.so pytest tests/test_internals_database.py ``` | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Test failures with SQLite 3.37.0+ due to column affinity case 1160407071 | |
| 1059821674 | https://github.com/simonw/datasette/issues/1647#issuecomment-1059821674 | https://api.github.com/repos/simonw/datasette/issues/1647 | IC_kwDOBm6k_c4_K5hq | simonw 9599 | 2022-03-05T19:44:32Z | 2022-03-05T19:44:32Z | OWNER | I thought I'd need to introduce https://dirty-equals.helpmanual.io/types/string/ to help write tests for this, but I think I've found a good alternative that doesn't need a new dependency. | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Test failures with SQLite 3.37.0+ due to column affinity case 1160407071 | |
| 1059823119 | https://github.com/simonw/datasette/issues/1647#issuecomment-1059823119 | https://api.github.com/repos/simonw/datasette/issues/1647 | IC_kwDOBm6k_c4_K54P | simonw 9599 | 2022-03-05T19:56:27Z | 2022-03-05T19:56:27Z | OWNER | Updated this TIL with extra patterns I figured out: https://til.simonwillison.net/sqlite/ld-preload | {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} | Test failures with SQLite 3.37.0+ due to column affinity case 1160407071 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] (
[html_url] TEXT,
[issue_url] TEXT,
[id] INTEGER PRIMARY KEY,
[node_id] TEXT,
[user] INTEGER REFERENCES [users]([id]),
[created_at] TEXT,
[updated_at] TEXT,
[author_association] TEXT,
[body] TEXT,
[reactions] TEXT,
[issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
ON [issue_comments] ([user]);