issue_comments

Table actions

10 rows where issue = 1170355774

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

id ▼ html_url issue_url node_id user created_at updated_at author_association body reactions issue performed_via_github_app
1068553454 https://github.com/simonw/datasette/issues/1661#issuecomment-1068553454 https://api.github.com/repos/simonw/datasette/issues/1661 IC_kwDOBm6k_c4_sNTu simonw 9599 2022-03-15T23:14:37Z 2022-03-15T23:14:37Z OWNER This is going to simplify the code in the various view classes substantially: - #1660 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Remove Hashed URL mode 1170355774  
1068554827 https://github.com/simonw/datasette/issues/1661#issuecomment-1068554827 https://api.github.com/repos/simonw/datasette/issues/1661 IC_kwDOBm6k_c4_sNpL simonw 9599 2022-03-15T23:16:58Z 2022-03-15T23:18:58Z OWNER If you attempt to use the [old setting](https://docs.datasette.io/en/stable/settings.html#hash-urls): datasette mydatabase.db --setting hash_urls 1 It should error with a message saying that the feature has been moved to a plugin. I'll do this with a `deprecated_settings` mechanism so the error can be detected even though `datasette --help-settings` will no longer return the setting. https://github.com/simonw/datasette/blob/77a904fea14f743560af9cc668146339bdbbd0a9/datasette/cli.py#L479-L489 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Remove Hashed URL mode 1170355774  
1068628839 https://github.com/simonw/datasette/issues/1661#issuecomment-1068628839 https://api.github.com/repos/simonw/datasette/issues/1661 IC_kwDOBm6k_c4_sftn simonw 9599 2022-03-16T01:21:36Z 2022-03-16T01:21:48Z OWNER From https://docs.datasette.io/en/0.60.2/performance.html#hashed-url-mode > You can enable these hashed URLs in two ways: using the [hash_urls](https://docs.datasette.io/en/0.60.2/settings.html#setting-hash-urls) configuration setting (which affects all requests to Datasette) or via the `?_hash=1` query string parameter (which only applies to the current request). I'm going to drop` ?_hash=1` entirely. I'd actually forgotten that feature existed! {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Remove Hashed URL mode 1170355774  
1068630353 https://github.com/simonw/datasette/issues/1661#issuecomment-1068630353 https://api.github.com/repos/simonw/datasette/issues/1661 IC_kwDOBm6k_c4_sgFR simonw 9599 2022-03-16T01:24:56Z 2022-03-16T01:25:49Z OWNER Here's the only bit of code that references that `_hash` mechanism: https://github.com/simonw/datasette/blob/77a904fea14f743560af9cc668146339bdbbd0a9/datasette/views/base.py#L259-L265 And here's the test: https://github.com/simonw/datasette/blob/77a904fea14f743560af9cc668146339bdbbd0a9/tests/test_api.py#L828-L854 Related issue: - #471 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Remove Hashed URL mode 1170355774  
1068728484 https://github.com/simonw/datasette/issues/1661#issuecomment-1068728484 https://api.github.com/repos/simonw/datasette/issues/1661 IC_kwDOBm6k_c4_s4Ck simonw 9599 2022-03-16T04:47:39Z 2022-03-16T04:47:39Z OWNER https://datasette.io/plugins/datasette-hashed-urls is released now. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Remove Hashed URL mode 1170355774  
1071706993 https://github.com/simonw/datasette/issues/1661#issuecomment-1071706993 https://api.github.com/repos/simonw/datasette/issues/1661 IC_kwDOBm6k_c4_4PNx simonw 9599 2022-03-17T22:42:21Z 2022-03-17T22:42:21Z OWNER As part of this I'm going to get rid of this mechanism: https://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/views/base.py#L170-L173 Unwrapping `request.scope["url_route"]["kwargs"]` into keyword argument to view functions just made the code harder to follow. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Remove Hashed URL mode 1170355774  
1071793307 https://github.com/simonw/datasette/issues/1661#issuecomment-1071793307 https://api.github.com/repos/simonw/datasette/issues/1661 IC_kwDOBm6k_c4_4kSb simonw 9599 2022-03-17T23:17:32Z 2022-03-17T23:17:32Z OWNER Surprisingly I managed to break https://latest.datasette.io/fixtures/custom_foreign_key_label while working on this change: ![CleanShot 2022-03-17 at 16 16 54@2x](https://user-images.githubusercontent.com/9599/158909271-717b65e8-cfcc-44c4-b1cc-f34478b0f803.png) {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Remove Hashed URL mode 1170355774  
1071797707 https://github.com/simonw/datasette/issues/1661#issuecomment-1071797707 https://api.github.com/repos/simonw/datasette/issues/1661 IC_kwDOBm6k_c4_4lXL simonw 9599 2022-03-17T23:19:24Z 2022-03-17T23:19:24Z OWNER Moving this to PR so I can comment on individual lines: - #1664 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Remove Hashed URL mode 1170355774  
1072901159 https://github.com/simonw/datasette/issues/1661#issuecomment-1072901159 https://api.github.com/repos/simonw/datasette/issues/1661 IC_kwDOBm6k_c4_8ywn simonw 9599 2022-03-19T00:20:27Z 2022-03-19T00:20:27Z OWNER I can remove the `default_cache_ttl_hashed` setting too. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Remove Hashed URL mode 1170355774  
1072904703 https://github.com/simonw/datasette/issues/1661#issuecomment-1072904703 https://api.github.com/repos/simonw/datasette/issues/1661 IC_kwDOBm6k_c4_8zn_ simonw 9599 2022-03-19T00:37:36Z 2022-03-19T00:37:36Z OWNER Updated docs: https://docs.datasette.io/en/latest/performance.html#datasette-hashed-urls {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} Remove Hashed URL mode 1170355774  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);