issue_comments

Table actions

13 rows where issue = 1334628400

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: user, author_association, reactions, created_at (date), updated_at (date)

id ▼ html_url issue_url node_id user created_at updated_at author_association body reactions issue performed_via_github_app
1210675046 https://github.com/simonw/datasette/issues/1779#issuecomment-1210675046 https://api.github.com/repos/simonw/datasette/issues/1779 IC_kwDOBm6k_c5IKW9m fgregg 536941 2022-08-10T13:28:37Z 2022-08-10T13:28:37Z CONTRIBUTOR maybe a simpler solution is to set the maxscale to like 2? since datasette is not set up to make use of container scaling anyway? {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} google cloudrun updated their limits on maxscale based on memory and cpu count 1334628400  
1214411951 https://github.com/simonw/datasette/issues/1779#issuecomment-1214411951 https://api.github.com/repos/simonw/datasette/issues/1779 IC_kwDOBm6k_c5IYnSv simonw 9599 2022-08-14T16:36:55Z 2022-08-14T16:36:55Z OWNER I'm going to default maxscale to 2 but provide an extra command line option for `datasette publish cloudrun` which lets people set it to something higher if they want to. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} google cloudrun updated their limits on maxscale based on memory and cpu count 1334628400  
1214412135 https://github.com/simonw/datasette/issues/1779#issuecomment-1214412135 https://api.github.com/repos/simonw/datasette/issues/1779 IC_kwDOBm6k_c5IYnVn simonw 9599 2022-08-14T16:38:08Z 2022-08-14T16:38:08Z OWNER Actually I disagree that Datasette isn't setup to make use of container scaling: part of the idea behind the [Baked Data](https://simonwillison.net/2021/Jul/28/baked-data/) pattern is that you can scale to handle effectively unlimited traffic by running multiple copies of your application, each with their own duplicate copy of the database. So I'm going to default maxScale to 10 and still let people customize it. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} google cloudrun updated their limits on maxscale based on memory and cpu count 1334628400  
1214412382 https://github.com/simonw/datasette/issues/1779#issuecomment-1214412382 https://api.github.com/repos/simonw/datasette/issues/1779 IC_kwDOBm6k_c5IYnZe simonw 9599 2022-08-14T16:40:02Z 2022-08-14T16:40:02Z OWNER Here's the relevant part of the `datasette publish` command from that failed Actions workflow: ``` datasette publish cloudrun f7.db nlrb.db opdr.db old_nlrb.db voluntary_recognitions.db work_stoppages.db lm20.db chips.db \ --memory 8Gi \ --cpu 2 ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} google cloudrun updated their limits on maxscale based on memory and cpu count 1334628400  
1214413161 https://github.com/simonw/datasette/issues/1779#issuecomment-1214413161 https://api.github.com/repos/simonw/datasette/issues/1779 IC_kwDOBm6k_c5IYnlp simonw 9599 2022-08-14T16:45:36Z 2022-08-14T16:45:36Z OWNER Tried duplicating this error locally but the following command succeeded when I expected it to fail: datasette publish cloudrun fixtures.db --memory 8Gi --cpu 2 --service issue-1779 {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} google cloudrun updated their limits on maxscale based on memory and cpu count 1334628400  
1214413419 https://github.com/simonw/datasette/issues/1779#issuecomment-1214413419 https://api.github.com/repos/simonw/datasette/issues/1779 IC_kwDOBm6k_c5IYnpr simonw 9599 2022-08-14T16:47:27Z 2022-08-14T16:47:27Z OWNER Maybe I need to upgrade: ``` % gcloud --version Google Cloud SDK 378.0.0 alpha 2022.03.18 bq 2.0.74 core 2022.03.18 gsutil 5.8 Updates are available for some Google Cloud CLI components. To install them, please run: $ gcloud components update ``` ``` % gcloud components update Beginning update. This process may take several minutes. Your current Google Cloud CLI version is: 378.0.0 You will be upgraded to version: 397.0.0 ┌─────────────────────────────────────────────────────────────────────────────┐ │ These components will be updated. │ ├─────────────────────────────────────────────────────┬────────────┬──────────┤ │ Name │ Version │ Size │ ├─────────────────────────────────────────────────────┼────────────┼──────────┤ │ BigQuery Command Line Tool │ 2.0.75 │ 1.6 MiB │ │ BigQuery Command Line Tool (Platform Specific) │ 2.0.75 │ < 1 MiB │ │ Cloud Storage Command Line Tool │ 5.11 │ 15.5 MiB │ │ Cloud Storage Command Line Tool (Platform Specific) │ 5.11 │ < 1 MiB │ │ Google Cloud CLI Core Libraries │ 2022.08.05 │ 24.3 MiB │ │ Google Cloud CLI Core Libraries (Platform Specific) │ 2022.08.05 │ < 1 MiB │ │ anthoscli │ 0.2.28 │ 48.0 MiB │ │ gcloud Alpha Commands │ 2022.08.05 │ < 1 MiB │ │ gcloud cli dependencies │ 2022.07.29 │ 11.2 MiB │ └─────────────────────────────────────────────────────┴────────────┴──────────┘ A lot has changed since your last upgrade. For the latest full release notes, please visit: https://cloud.google.com/sdk/release_notes ``` ``` % gcloud --version Google Cloud SDK 397.0.0 alpha 2022.08.05 bq 2.0.75 core 2022.08.05 gsutil 5.11 ``` {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} google cloudrun updated their limits on maxscale based on memory and cpu count 1334628400  
1214413534 https://github.com/simonw/datasette/issues/1779#issuecomment-1214413534 https://api.github.com/repos/simonw/datasette/issues/1779 IC_kwDOBm6k_c5IYnre simonw 9599 2022-08-14T16:48:28Z 2022-08-14T16:48:28Z OWNER `datasette publish cloudrun fixtures.db --memory 8Gi --cpu 2 --service issue-1779` still works. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} google cloudrun updated their limits on maxscale based on memory and cpu count 1334628400  
1214413750 https://github.com/simonw/datasette/issues/1779#issuecomment-1214413750 https://api.github.com/repos/simonw/datasette/issues/1779 IC_kwDOBm6k_c5IYnu2 simonw 9599 2022-08-14T16:50:08Z 2022-08-14T16:50:08Z OWNER Just spotted this in the failing Actions workflow: gcloud config set run/region us-central1 I tried that locally too but the deploy still succeeds. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} google cloudrun updated their limits on maxscale based on memory and cpu count 1334628400  
1214414013 https://github.com/simonw/datasette/issues/1779#issuecomment-1214414013 https://api.github.com/repos/simonw/datasette/issues/1779 IC_kwDOBm6k_c5IYny9 simonw 9599 2022-08-14T16:52:14Z 2022-08-14T16:52:14Z OWNER Just tried this instead, and it still worked and deployed OK: datasette publish cloudrun fixtures.db --memory 16Gi --cpu 4 --service issue-1779 @fgregg I'm not able to replicate your deployment failure I'm afraid. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} google cloudrun updated their limits on maxscale based on memory and cpu count 1334628400  
1214414320 https://github.com/simonw/datasette/issues/1779#issuecomment-1214414320 https://api.github.com/repos/simonw/datasette/issues/1779 IC_kwDOBm6k_c5IYn3w simonw 9599 2022-08-14T16:54:32Z 2022-08-14T16:54:32Z OWNER (I deleted my `issue-1779` project using the UI at https://console.cloud.google.com/run?project=datasette-222320) {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} google cloudrun updated their limits on maxscale based on memory and cpu count 1334628400  
1214414471 https://github.com/simonw/datasette/issues/1779#issuecomment-1214414471 https://api.github.com/repos/simonw/datasette/issues/1779 IC_kwDOBm6k_c5IYn6H simonw 9599 2022-08-14T16:55:40Z 2022-08-14T16:55:40Z OWNER Here's the start of the man page for `gcloud run deploy`: ``` NAME gcloud run deploy - deploy a container to Cloud Run SYNOPSIS gcloud run deploy [[SERVICE] --namespace=NAMESPACE] [--args=[ARG,...]] [--async] [--command=[COMMAND,...]] [--concurrency=CONCURRENCY] [--cpu=CPU] [--ingress=INGRESS; default="all"] [--max-instances=MAX_INSTANCES] [--memory=MEMORY] [--min-instances=MIN_INSTANCES] ``` I'm going to expose `--max-instances` and `--min-instances` as extra option to `datasette publish cloudrun`. {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} google cloudrun updated their limits on maxscale based on memory and cpu count 1334628400  
1214416491 https://github.com/simonw/datasette/issues/1779#issuecomment-1214416491 https://api.github.com/repos/simonw/datasette/issues/1779 IC_kwDOBm6k_c5IYoZr simonw 9599 2022-08-14T17:07:34Z 2022-08-14T17:07:34Z OWNER Tested that with: datasette publish cloudrun fixtures.db --service issue-1779 --min-instances 2 --max-instances 4 <img width="1303" alt="image" src="https://user-images.githubusercontent.com/9599/184547516-5882f41c-0952-4cac-ae33-c79db7ceada9.png"> {"total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} google cloudrun updated their limits on maxscale based on memory and cpu count 1334628400  
1214437408 https://github.com/simonw/datasette/issues/1779#issuecomment-1214437408 https://api.github.com/repos/simonw/datasette/issues/1779 IC_kwDOBm6k_c5IYtgg fgregg 536941 2022-08-14T19:42:58Z 2022-08-14T19:42:58Z CONTRIBUTOR thanks @simonw! {"total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0} google cloudrun updated their limits on maxscale based on memory and cpu count 1334628400  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);